Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ensure site_url and use_directory_urls do not conflict." #2490

Merged
merged 1 commit into from Jul 12, 2021

Conversation

@oprypin
Copy link
Member

@oprypin oprypin commented Jul 8, 2021

This reverts commit b89ec57 (#2405)

That commit claims to fix some bugs in interactions with use_directory_urls, but in fact there are currently no known unfixed bugs.
So there is no need to have that breaking change.

See #2189 (comment)

Closes #2189
Closes #2479

This reverts commit b89ec57.

That commit claims to fix some bugs in interactions with `use_directory_urls`, but in fact there are currently no known unfixed bugs.
So there is no need to have that breaking change.
@oprypin
Copy link
Member Author

@oprypin oprypin commented Jul 11, 2021

I intend to merge this in 1 day

@oprypin oprypin merged commit ae55657 into mkdocs:master Jul 12, 2021
20 checks passed
jholdstock added a commit to jholdstock/dcrdocs that referenced this issue Aug 3, 2021
No longer need site_url in mkdocs.yml (mkdocs/mkdocs#2490)
dajohi added a commit to decred/dcrdocs that referenced this issue Sep 10, 2021
No longer need site_url in mkdocs.yml (mkdocs/mkdocs#2490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants