Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana-agent] add Grafana Agent #140

Merged
merged 8 commits into from
Aug 26, 2022

Conversation

sbaerlocher
Copy link
Contributor

Description

Addition of the Grafana Agent: https://grafana.com/docs/agent/latest/

Motivation and Context

Since the Grafana packages are already maintained by you, I thought that your repository for the agent is the right place.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Owner

@mkevenaar mkevenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sbaerlocher,

Thank you for submitting this package, I have some small requests that needs to be changed. Could you update these please?

Thanks

automatic/grafana-agent/grafana-agent.nuspec Outdated Show resolved Hide resolved
automatic/grafana-agent/README.md Outdated Show resolved Hide resolved
automatic/grafana-agent/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Owner

@mkevenaar mkevenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@mkevenaar mkevenaar merged commit 63d07e0 into mkevenaar:master Aug 26, 2022
@mkevenaar
Copy link
Owner

@sbaerlocher your changes have been merged, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants