Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ZeroTier-One) Correct installer name and URL inconsistency #244

Merged
merged 1 commit into from
Jun 1, 2024
Merged

(ZeroTier-One) Correct installer name and URL inconsistency #244

merged 1 commit into from
Jun 1, 2024

Conversation

drfuzzyness
Copy link
Contributor

@drfuzzyness drfuzzyness commented May 31, 2024 •
edited
Loading

Description

Resolves #240 by correcting the installer name inconsistency with the URL. The official ZeroTier One source now include an installer with no spaces in the name: ZeroTierOne.msi so the URL encoding issue can be resolved by simply not using a space in the name.

Motivation and Context

Resolves #240

How Has this Been Tested?

Success!

`update.ps1` 
❯ $au_Force = $true;.\update.ps1
zerotier-one - checking updates using Chocolatey-AU version 1.0.0

URL check
https://download.zerotier.com/RELEASES/1.14.0/dist/ZeroTierOne.msi
nuspec version: 1.14.0
remote version: 1.14.0
No new version found, but update is forced
New version is available
Automatic checksum skipped
Running au_BeforeUpdate
Purging msi
Downloading to ZeroTierOne.msi - https://download.zerotier.com/RELEASES/1.14.0/dist/ZeroTierOne.msi
Setting package description from README.md
Updating files
$Latest data:
  Checksum32                (String)     4F844EB5632CB7484499BA1B237D91FB2FD4E97176864EDE6E74AD33C599C135
  ChecksumType32            (String)     sha256
  FileName32                (String)     ZeroTierOne.msi
  FileType                  (String)     msi
  NuspecVersion             (String)     1.14.0
  PackageName               (String)     zerotier-one
  URL32                     (String)     https://download.zerotier.com/RELEASES/1.14.0/dist/ZeroTierOne.msi  
  Version                   (AUVersion)  1.14.0.20240531
zerotier-one.nuspec
  setting id: zerotier-one
  using Chocolatey fix notation: 1.14.0 -> 1.14.0.20240531
.\legal\VERIFICATION.txt
  (?i)(checksum type:).*              = ${1} sha256
  (?i)(32-Bit.+)\<.*\>                = ${1}<https://download.zerotier.com/RELEASES/1.14.0/dist/ZeroTierOne.msi>
  (?i)(checksum32:).*                 = ${1} 4F844EB5632CB7484499BA1B237D91FB2FD4E97176864EDE6E74AD33C599C135    (?i)(listed on\s*)\<.*\>            = ${1}<https://github.com/zerotier/ZeroTierOne/releases/latest>        
.\tools\chocolateyInstall.ps1
  (?i)(^\s*file\s*=\s*"[$]toolsDir\\).* = ${1}ZeroTierOne.msi"
Attempting to build package from 'zerotier-one.nuspec'.
Successfully created package 'C:\XXX\chocolatey-packages\automatic\zerotier-one\zerotier-one.1.14.0.20240531.nupkg'

Package updated

Path          : C:\XXX\chocolatey-packages\automatic\zerotier-one
Name          : zerotier-one
Updated       : True
Pushed        : False
RemoteVersion : 1.14.0.20240531
NuspecVersion : 1.14.0
Result        : {zerotier-one - checking updates using Chocolatey-AU version 1.0.0, , URL check,
              https://download.zerotier.com/RELEASES/1.14.0/dist/ZeroTierOne.msi…}
Error         : 
NuspecPath    : C:\XXX\chocolatey-packages\automatic\zerotier-one\zerotier-one.nuspe 
              c
NuspecXml     : #document
Ignored       : False
IgnoreMessage : 
StreamsPath   : C:\XXX\Playground\chocolatey-packages\automatic\zerotier-one\zerotier-one.json  
Streams       :
`choco.exe install -fdvy zerotier-one --version 1.14.0.20240531 --allow-downgrade --source "'C:\packages'"` 
❯ choco.exe install -fdvy zerotier-one  --version 1.14.0.20240531 --allow-downgrade --source "'C:\packages'"

Chocolatey v2.2.2
Chocolatey is running on Windows v 10.0.19045.0
Attempting to delete file "C:/ProgramData/chocolatey/choco.exe.old".
Attempting to delete file "C:\ProgramData\chocolatey\choco.exe.old".
Command line: "C:\ProgramData\chocolatey\choco.exe" install -fdvy zerotier-one --version 1.14.0.20240531 --allow-downgrade --source 'C:\packages'
Received arguments: install -fdvy zerotier-one --version 1.14.0.20240531 --allow-downgrade --source 'C:\packages'
RemovePendingPackagesTask is now ready and waiting for PreRunMessage.
Sending message 'PreRunMessage' out if there are subscribers...
[Pending] Removing all pending packages that should not be considered installed...
Performing validation checks.
Global Configuration Validation Checks:
- Package Exit Code / Exit On Reboot = Checked
System State Validation Checks:
Reboot Requirement Checks:
- Pending Computer Rename = Checked
- Pending Component Based Servicing = Checked
- Pending Windows Auto Update = Checked
- Pending File Rename Operations = Ignored
- Pending Windows Package Installer = Checked
- Pending Windows Package Installer SysWow64 = Checked
Cache Folder Lockdown Checks:
- Elevated State = Checked
- Folder Exists = Checked
- Folder lockdown = Checked
The source 'C:\packages' evaluated to a 'normal' source type

NOTE: Hiding sensitive configuration data! Please double and triple
check to be sure no sensitive data is shown, especially if copying
output to a gist for review.
Configuration: CommandName='install'|
CacheLocation='C:\Users\Matthew\AppData\Local\Temp\chocolatey'|
CommandExecutionTimeoutSeconds='2700'|WebRequestTimeoutSeconds='30'|
Sources='C:\packages'|SourceType='normal'|ShowOnlineHelp='False'|
Debug='True'|Verbose='True'|Trace='False'|Force='True'|Noop='False'|
HelpRequested='False'|UnsuccessfulParsing='False'|RegularOutput='True'|
QuietOutput='False'|PromptForConfirmation='False'|
DisableCompatibilityChecks='False'|AcceptLicense='True'|
AllowUnofficialBuild='False'|Input='zerotier-one'|
Version='1.14.0.20240531'|AllVersions='False'|
SkipPackageInstallProvider='False'|SkipHookScripts='False'|
PackageNames='zerotier-one'|Prerelease='False'|ForceX86='False'|
OverrideArguments='False'|NotSilent='False'|
ApplyPackageParametersToDependencies='False'|
ApplyInstallArgumentsToDependencies='False'|IgnoreDependencies='False'|
CacheExpirationInMinutes='30'|AllowDowngrade='True'|
ForceDependencies='False'|PinPackage='False'|
Information.PlatformType='Windows'|
Information.PlatformVersion='10.0.19045.0'|
Information.PlatformName='Windows 10'|
Information.ChocolateyVersion='2.2.2.0'|
Information.ChocolateyProductVersion='2.2.2'|
Information.FullName='choco, Version=2.2.2.0, Culture=neutral, PublicKeyToken=79d02ea9cad655eb'|

Information.Is64BitOperatingSystem='True'|
Information.Is64BitProcess='True'|Information.IsInteractive='True'|
Information.UserName='Matthew'|
Information.UserDomainName='DGTL-ZG15-MATTH'|
Information.IsUserAdministrator='True'|
Information.IsUserSystemAccount='False'|
Information.IsUserRemoteDesktop='False'|
Information.IsUserRemote='False'|Information.IsProcessElevated='True'|
Information.IsLicensedVersion='False'|
Information.IsLicensedAssemblyLoaded='False'|
Information.LicenseType='Foss'|
Information.CurrentDirectory='C:\Users\Matthew'|
Features.AutoUninstaller='True'|Features.ChecksumFiles='True'|
Features.AllowEmptyChecksums='False'|
Features.AllowEmptyChecksumsSecure='True'|
Features.FailOnAutoUninstaller='False'|
Features.FailOnStandardError='False'|Features.UsePowerShellHost='True'|
Features.LogEnvironmentValues='False'|Features.LogWithoutColor='False'|
Features.VirusCheck='False'|
Features.FailOnInvalidOrMissingLicense='False'|
Features.IgnoreInvalidOptionsSwitches='True'|
Features.UsePackageExitCodes='True'|
Features.UseEnhancedExitCodes='False'|
Features.UseFipsCompliantChecksums='False'|
Features.ShowNonElevatedWarnings='True'|
Features.ShowDownloadProgress='True'|
Features.StopOnFirstPackageFailure='False'|
Features.UseRememberedArgumentsForUpgrades='False'|
Features.IgnoreUnfoundPackagesOnUpgradeOutdated='False'|
Features.SkipPackageUpgradesWhenNotInstalled='False'|
Features.RemovePackageInformationOnUninstall='False'|
Features.ExitOnRebootDetected='False'|
Features.LogValidationResultsOnWarnings='True'|
Features.UsePackageRepositoryOptimizations='True'|
ListCommand.LocalOnly='False'|ListCommand.IdOnly='False'|
ListCommand.IncludeRegistryPrograms='False'|ListCommand.PageSize='25'|
ListCommand.Exact='False'|ListCommand.ByIdOnly='False'|
ListCommand.ByTagOnly='False'|ListCommand.IdStartsWith='False'|
ListCommand.OrderByPopularity='False'|ListCommand.ApprovedOnly='False'|
ListCommand.DownloadCacheAvailable='False'|
ListCommand.NotBroken='False'|
ListCommand.IncludeVersionOverrides='False'|
ListCommand.ExplicitPageSize='False'|
ListCommand.ExplicitSource='False'|
UpgradeCommand.FailOnUnfound='False'|
UpgradeCommand.FailOnNotInstalled='False'|
UpgradeCommand.NotifyOnlyAvailableUpgrades='False'|
UpgradeCommand.ExcludePrerelease='False'|
NewCommand.AutomaticPackage='False'|
NewCommand.UseOriginalTemplate='False'|SourceCommand.Command='unknown'|
SourceCommand.Priority='0'|SourceCommand.BypassProxy='False'|
SourceCommand.AllowSelfService='False'|
SourceCommand.VisibleToAdminsOnly='False'|
FeatureCommand.Command='unknown'|ConfigCommand.Command='Unknown'|
ApiKeyCommand.Command='Unknown'|PinCommand.Command='Unknown'|
OutdatedCommand.IgnorePinned='False'|
ExportCommand.IncludeVersionNumbers='False'|Proxy.BypassOnLocal='True'|
TemplateCommand.Command='unknown'|CacheCommand.Command='Unknown'|
CacheCommand.RemoveExpiredItemsOnly='False'|
_ Chocolatey:ChocolateyInstallCommand - Normal Run Mode _
Installing the following packages:
zerotier-one
By installing, you accept licenses for the packages.
Running list with the following filter = ''
--- Start of List ---
Resolving resource PackageSearchResource for source C:\ProgramData\chocolatey\lib
act-cli 0.2.62
adb 34.0.5
angryip 3.9.1.20240209
audacity 3.5.1
audacity-ffmpeg 2.2.2.20210809
audacity-lame 3.100.0.20190331
autohotkey.portable 2.0.16
azure-cli 2.61.0
barrier 2.4.0.2
bitwarden 2024.5.0
bitwarden-cli 2024.4.1
bruno 1.18.1
chocolatey 2.2.2
chocolatey-compatibility.extension 1.0.0
chocolatey-core.extension 1.4.0
chocolatey-dotnetfx.extension 1.0.1
chocolatey-font-helpers.extension 0.0.4
chocolatey-windowsupdate.extension 1.0.5
chromium 125.0.6422.113
dotnet-6.0-desktopruntime 6.0.31
dotnet-7.0-desktopruntime 7.0.20
dotnet-8.0-desktopruntime 8.0.6
dotnet-desktopruntime 8.0.6
dotnetfx 4.8.0.20220524
drawio 24.4.8
ffmpeg 7.0.1
FileOptimizer 16.60.2819
firacodenf 6.2.0
flow-launcher 1.18.0
fontbase 2.20.7
fontforge 2023.1.1
fspy 1.0.3
git 2.45.1
git.install 2.45.1
git-lfs 3.5.1
git-lfs.install 3.5.1
handbrake 1.8.0.20240522
handbrake.install 1.8.0.20240522
imagemagick.app 7.1.1.3300
joplin 2.14.22
KB2919355 1.0.20160915
KB2919442 1.0.20160915
KB2999226 1.0.20181019
KB3033929 1.0.5
KB3035131 1.0.3
KB3063858 1.0.0
keypirinha 2.26.0
k-litecodecpackmega 18.3.0
mac-precision-touchpad 0.2105.3979
monaspace 1.101.0
nextcloud-client 3.13.0
nvm 1.1.12
nvm.install 1.1.12
obs-studio 30.1.2
obs-studio.install 30.1.2
openjdk 22.0.1
openssh 9.5.0-beta20240403
powertoys 0.81.1
python310 3.10.11
python312 3.12.3
python38 3.8.10
quicklook 3.7.3
rufus 4.5.0
sharex 16.1.0
shexview 2.1.0
shmnview 1.41.0
starship 1.19.0
starship.install 1.19.0
tftpd32 4.64.20200902
unifying 2.52.33
vagrant 2.4.1
vcredist140 14.40.33810
vcredist2010 10.0.40219.32503
vcredist2015 14.0.24215.20170201
vcredist2017 14.16.27033
vlc 3.0.20
vlc.install 3.0.20
vnc-viewer 7.7.0
win10mct 10.0.19041.572
win32diskimager 1.0.0.20181220
win32diskimager.install 1.0.0.20181220
windirstat 1.1.2.20161210
windows10-media-creation-tool 10.0.19041.572
winscp 6.3.3
winscp.install 6.3.3
wireshark 4.2.5
youtube-dl 2021.12.17
yt-dlp 2024.5.27
zerotier-one 1.12.2
--- End of List ---
Resolving resource PackageMetadataResource for source C:\packages
Resolving resource DependencyInfoResource for source C:\packages
[NuGet] Resolving dependency information took 0 ms
Running beforeModify step for 'zerotier-one'
Backing up package files for 'zerotier-one'
Attempting to create directory "C:\ProgramData\chocolatey\lib-bkp\zerotier-one".
Moving C:\ProgramData\chocolatey\lib\zerotier-one to C:\ProgramData\chocolatey\lib-bkp\zerotier-one\1.12.2
Moving 'C:\ProgramData\chocolatey\lib\zerotier-one'
to 'C:\ProgramData\chocolatey\lib-bkp\zerotier-one\1.12.2'
Attempting to create directory "C:\ProgramData\chocolatey\lib\zerotier-one".
Attempting to copy "C:\ProgramData\chocolatey\lib-bkp\zerotier-one\1.12.2\zerotier-one.nupkg"
to "C:\ProgramData\chocolatey\lib\zerotier-one\zerotier-one.nupkg".
Attempting to copy "C:\ProgramData\chocolatey\lib-bkp\zerotier-one\1.12.2\zerotier-one.nuspec"
to "C:\ProgramData\chocolatey\lib\zerotier-one\zerotier-one.nuspec".
Attempting to create directory "C:\ProgramData\chocolatey\lib\zerotier-one\legal".
Attempting to copy "C:\ProgramData\chocolatey\lib-bkp\zerotier-one\1.12.2\legal\LICENSE.txt"
to "C:\ProgramData\chocolatey\lib\zerotier-one\legal\LICENSE.txt".
Attempting to copy "C:\ProgramData\chocolatey\lib-bkp\zerotier-one\1.12.2\legal\VERIFICATION.txt"
to "C:\ProgramData\chocolatey\lib\zerotier-one\legal\VERIFICATION.txt".
Attempting to create directory "C:\ProgramData\chocolatey\lib\zerotier-one\tools".
Attempting to copy "C:\ProgramData\chocolatey\lib-bkp\zerotier-one\1.12.2\tools\chocolateyinstall.ps1"
to "C:\ProgramData\chocolatey\lib\zerotier-one\tools\chocolateyinstall.ps1".
Attempting to copy "C:\ProgramData\chocolatey\lib-bkp\zerotier-one\1.12.2\tools\ZeroTier%20One.msi"
to "C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTier%20One.msi".
Attempting to copy "C:\ProgramData\chocolatey\lib-bkp\zerotier-one\1.12.2\tools\ZeroTier%20One.msi.ignore"
to "C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTier%20One.msi.ignore".
Capturing package files in 'C:\ProgramData\chocolatey\lib\zerotier-one'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\zerotier-one.nupkg'
with checksum '1BCB0FB377F91AF520B14F07D78F5830'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\zerotier-one.nuspec'
with checksum '852318DB7C7D118812DEFD4EEE55F1B6'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\legal\LICENSE.txt'
with checksum 'FAC5E752C563701DE2B3EB9F13C2BCC3'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\legal\VERIFICATION.txt'
with checksum '0E500AAFA7D6907B5D2CB9DB59594042'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\chocolateyinstall.ps1'
with checksum 'A2C67621605984A6FE14A808594A18F7'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTier%20One.msi'
with checksum 'DD9877F752CA575E329AFAD2177293CF'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTier%20One.msi.ignore'
with checksum 'BEA07E6D2B8DCE396FE21BAA61B34956'
Attempting to delete file "C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTier%20One.msi.ignore".
[NuGet] Removed folder 'C:\ProgramData\chocolatey\lib\zerotier-one\tools'.
[NuGet] Removed folder 'C:\ProgramData\chocolatey\lib\zerotier-one\legal'.
[NuGet] Removed file 'zerotier-one.nupkg' from folder 'C:\ProgramData\chocolatey\lib\zerotier-one'.
Ensuring removal of package cache files.
Resolving resource DownloadResource for source C:\packages
Attempting to delete file "".
[NuGet] Adding package 'zerotier-one.1.14.0.20240531' to folder 'C:\ProgramData\chocolatey\lib'
[NuGet] Added package 'zerotier-one.1.14.0.20240531' to folder 'C:\ProgramData\chocolatey\lib'
[NuGet] Added package 'zerotier-one.1.14.0.20240531' to folder 'C:\ProgramData\chocolatey\lib' from source 'C:\packages'

zerotier-one v1.14.0.20240531 (forced)
zerotier-one package files install completed. Performing other installation steps.
Setting installer args for zerotier-one
Setting package parameters for zerotier-one
Contents of 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\chocolateyinstall.ps1':
$ErrorActionPreference = 'Stop';

$toolsDir       = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)"

$packageArgs = @{
packageName   = $env:ChocolateyPackageName
fileType      = 'msi'
file          = "$toolsDir\ZeroTierOne.msi"
softwareName  = 'ZeroTier One*'
silentArgs    = "/qn /norestart /l*v `"$env:TEMP\$env:ChocolateyPackageName.$env:ChocolateyPackageVersion.log`""
validExitCodes= @(0,3010)
}

Install-ChocolateyInstallPackage @packageArgs


Calling built-in PowerShell host with ['[System.Threading.Thread]::CurrentThread.CurrentCulture = '';[System.Threading.Thread]::CurrentThread.CurrentUICulture = '';[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::SystemDefault; & import-module -name 'C:\ProgramData\chocolatey\helpers\chocolateyInstaller.psm1'; & 'C:\ProgramData\chocolatey\helpers\chocolateyScriptRunner.ps1' -packageScript 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\chocolateyinstall.ps1' -installArguments '' -packageParameters '' -preRunHookScripts $null -postRunHookScripts $null']
Redirecting System.Management.Automation.resources, Version=3.0.0.0, Culture=en-US, PublicKeyToken=31bf3856ad364e35, requested by ''
Host version is 5.1.19041.1, PowerShell Version is '5.1.19041.4412' and CLR Version is '4.0.30319.42000'.
VERBOSE: Exporting function 'Format-FileSize'.
VERBOSE: Exporting function 'Get-ChecksumValid'.
VERBOSE: Exporting function 'Get-ChocolateyConfigValue'.
VERBOSE: Exporting function 'Get-ChocolateyPath'.
VERBOSE: Exporting function 'Get-ChocolateyUnzip'.
VERBOSE: Exporting function 'Get-ChocolateyWebFile'.
VERBOSE: Exporting function 'Get-EnvironmentVariable'.
VERBOSE: Exporting function 'Get-EnvironmentVariableNames'.
VERBOSE: Exporting function 'Get-FtpFile'.
VERBOSE: Exporting function 'Get-OSArchitectureWidth'.
VERBOSE: Exporting function 'Get-PackageParameters'.
VERBOSE: Exporting function 'Get-PackageParametersBuiltIn'.
VERBOSE: Exporting function 'Get-ToolsLocation'.
VERBOSE: Exporting function 'Get-UACEnabled'.
VERBOSE: Exporting function 'Get-UninstallRegistryKey'.
VERBOSE: Exporting function 'Get-VirusCheckValid'.
VERBOSE: Exporting function 'Get-WebFile'.
VERBOSE: Exporting function 'Get-WebFileName'.
VERBOSE: Exporting function 'Get-WebHeaders'.
VERBOSE: Exporting function 'Install-BinFile'.
VERBOSE: Exporting function 'Install-ChocolateyEnvironmentVariable'.
VERBOSE: Exporting function 'Install-ChocolateyExplorerMenuItem'.
VERBOSE: Exporting function 'Install-ChocolateyFileAssociation'.
VERBOSE: Exporting function 'Install-ChocolateyInstallPackage'.
VERBOSE: Exporting function 'Install-ChocolateyPackage'.
VERBOSE: Exporting function 'Install-ChocolateyPath'.
VERBOSE: Exporting function 'Install-ChocolateyPinnedTaskBarItem'.
VERBOSE: Exporting function 'Install-ChocolateyPowershellCommand'.
VERBOSE: Exporting function 'Install-ChocolateyShortcut'.
VERBOSE: Exporting function 'Install-ChocolateyVsixPackage'.
VERBOSE: Exporting function 'Install-ChocolateyZipPackage'.
VERBOSE: Exporting function 'Install-Vsix'.
VERBOSE: Exporting function 'Set-EnvironmentVariable'.
VERBOSE: Exporting function 'Set-PowerShellExitCode'.
VERBOSE: Exporting function 'Start-ChocolateyProcessAsAdmin'.
VERBOSE: Exporting function 'Test-ProcessAdminRights'.
VERBOSE: Exporting function 'Uninstall-BinFile'.
VERBOSE: Exporting function 'Uninstall-ChocolateyEnvironmentVariable'.
VERBOSE: Exporting function 'Uninstall-ChocolateyPackage'.
VERBOSE: Exporting function 'Uninstall-ChocolateyZipPackage'.
VERBOSE: Exporting function 'Update-SessionEnvironment'.
VERBOSE: Exporting function 'Write-FunctionCallLogMessage'.
VERBOSE: Exporting alias 'Get-ProcessorBits'.
VERBOSE: Exporting alias 'Get-OSBitness'.
VERBOSE: Exporting alias 'Get-InstallRegistryKey'.
VERBOSE: Exporting alias 'Generate-BinFile'.
VERBOSE: Exporting alias 'Add-BinFile'.
VERBOSE: Exporting alias 'Start-ChocolateyProcess'.
VERBOSE: Exporting alias 'Invoke-ChocolateyProcess'.
VERBOSE: Exporting alias 'Remove-BinFile'.
VERBOSE: Exporting alias 'refreshenv'.
Loading community extensions
Importing 'C:\ProgramData\chocolatey\extensions\chocolatey-compatibility\chocolatey-compatibility.psm1'
VERBOSE: Loading module from path 'C:\ProgramData\chocolatey\extensions\chocolatey-compatibility\chocolatey-compatibility.psm1'.
Function 'Get-PackageParameters' exists, ignoring export.
Function 'Get-UninstallRegistryKey' exists, ignoring export.
Exporting function 'Install-ChocolateyDesktopLink' for backwards compatibility
VERBOSE: Exporting function 'Install-ChocolateyDesktopLink'.
Exporting function 'Write-ChocolateyFailure' for backwards compatibility
VERBOSE: Exporting function 'Write-ChocolateyFailure'.
Exporting function 'Write-ChocolateySuccess' for backwards compatibility
VERBOSE: Exporting function 'Write-ChocolateySuccess'.
Exporting function 'Write-FileUpdateLog' for backwards compatibility
VERBOSE: Exporting function 'Write-FileUpdateLog'.
VERBOSE: Importing function 'Install-ChocolateyDesktopLink'.
VERBOSE: Importing function 'Write-ChocolateyFailure'.
VERBOSE: Importing function 'Write-ChocolateySuccess'.
VERBOSE: Importing function 'Write-FileUpdateLog'.
Importing 'C:\ProgramData\chocolatey\extensions\chocolatey-core\chocolatey-core.psm1'
VERBOSE: Loading module from path 'C:\ProgramData\chocolatey\extensions\chocolatey-core\chocolatey-core.psm1'.
VERBOSE: Exporting function 'Get-AppInstallLocation'.
VERBOSE: Exporting function 'Get-AvailableDriveLetter'.
VERBOSE: Exporting function 'Get-EffectiveProxy'.
VERBOSE: Exporting function 'Get-PackageCacheLocation'.
VERBOSE: Exporting function 'Get-WebContent'.
VERBOSE: Exporting function 'Register-Application'.
VERBOSE: Exporting function 'Remove-Process'.
VERBOSE: Importing function 'Get-AppInstallLocation'.
VERBOSE: Importing function 'Get-AvailableDriveLetter'.
VERBOSE: Importing function 'Get-EffectiveProxy'.
VERBOSE: Importing function 'Get-PackageCacheLocation'.
VERBOSE: Importing function 'Get-WebContent'.
VERBOSE: Importing function 'Register-Application'.
VERBOSE: Importing function 'Remove-Process'.
Importing 'C:\ProgramData\chocolatey\extensions\chocolatey-dotnetfx\chocolatey-dotnetfx.psm1'
VERBOSE: Loading module from path 'C:\ProgramData\chocolatey\extensions\chocolatey-dotnetfx\chocolatey-dotnetfx.psm1'.
VERBOSE: Exporting function 'Install-DotNetFramework'.
VERBOSE: Exporting function 'Install-DotNetDevPack'.
VERBOSE: Importing function 'Install-DotNetDevPack'.
VERBOSE: Importing function 'Install-DotNetFramework'.
Importing 'C:\ProgramData\chocolatey\extensions\chocolatey-font-helpers\FontHelp.psm1'
VERBOSE: Loading module from path 'C:\ProgramData\chocolatey\extensions\chocolatey-font-helpers\FontHelp.psm1'.
VERBOSE: Exporting function 'Install-ChocolateyFont'.
VERBOSE: Exporting function 'Uninstall-ChocolateyFont'.
VERBOSE: Exporting alias 'Add-Font'.
VERBOSE: Exporting alias 'Remove-Font'.
VERBOSE: Importing function 'Install-ChocolateyFont'.
VERBOSE: Importing function 'Uninstall-ChocolateyFont'.
VERBOSE: Importing alias 'Add-Font'.
VERBOSE: Importing alias 'Remove-Font'.
Importing 'C:\ProgramData\chocolatey\extensions\chocolatey-windowsupdate\chocolatey-windowsupdate.psm1'
VERBOSE: Loading module from path 'C:\ProgramData\chocolatey\extensions\chocolatey-windowsupdate\chocolatey-windowsupdate.psm1'.
VERBOSE: Exporting function 'Install-WindowsUpdate'.
VERBOSE: Exporting function 'Test-WindowsUpdate'.
VERBOSE: Importing function 'Install-WindowsUpdate'.
VERBOSE: Importing function 'Test-WindowsUpdate'.
VERBOSE: Exporting function 'Format-FileSize'.
VERBOSE: Exporting function 'Get-ChecksumValid'.
VERBOSE: Exporting function 'Get-ChocolateyConfigValue'.
VERBOSE: Exporting function 'Get-ChocolateyPath'.
VERBOSE: Exporting function 'Get-ChocolateyUnzip'.
VERBOSE: Exporting function 'Get-ChocolateyWebFile'.
VERBOSE: Exporting function 'Get-EnvironmentVariable'.
VERBOSE: Exporting function 'Get-EnvironmentVariableNames'.
VERBOSE: Exporting function 'Get-FtpFile'.
VERBOSE: Exporting function 'Get-OSArchitectureWidth'.
VERBOSE: Exporting function 'Get-PackageParameters'.
VERBOSE: Exporting function 'Get-PackageParametersBuiltIn'.
VERBOSE: Exporting function 'Get-ToolsLocation'.
VERBOSE: Exporting function 'Get-UACEnabled'.
VERBOSE: Exporting function 'Get-UninstallRegistryKey'.
VERBOSE: Exporting function 'Get-VirusCheckValid'.
VERBOSE: Exporting function 'Get-WebFile'.
VERBOSE: Exporting function 'Get-WebFileName'.
VERBOSE: Exporting function 'Get-WebHeaders'.
VERBOSE: Exporting function 'Install-BinFile'.
VERBOSE: Exporting function 'Install-ChocolateyEnvironmentVariable'.
VERBOSE: Exporting function 'Install-ChocolateyExplorerMenuItem'.
VERBOSE: Exporting function 'Install-ChocolateyFileAssociation'.
VERBOSE: Exporting function 'Install-ChocolateyInstallPackage'.
VERBOSE: Exporting function 'Install-ChocolateyPackage'.
VERBOSE: Exporting function 'Install-ChocolateyPath'.
VERBOSE: Exporting function 'Install-ChocolateyPinnedTaskBarItem'.
VERBOSE: Exporting function 'Install-ChocolateyPowershellCommand'.
VERBOSE: Exporting function 'Install-ChocolateyShortcut'.
VERBOSE: Exporting function 'Install-ChocolateyVsixPackage'.
VERBOSE: Exporting function 'Install-ChocolateyZipPackage'.
VERBOSE: Exporting function 'Install-Vsix'.
VERBOSE: Exporting function 'Set-EnvironmentVariable'.
VERBOSE: Exporting function 'Set-PowerShellExitCode'.
VERBOSE: Exporting function 'Start-ChocolateyProcessAsAdmin'.
VERBOSE: Exporting function 'Test-ProcessAdminRights'.
VERBOSE: Exporting function 'Uninstall-BinFile'.
VERBOSE: Exporting function 'Uninstall-ChocolateyEnvironmentVariable'.
VERBOSE: Exporting function 'Uninstall-ChocolateyPackage'.
VERBOSE: Exporting function 'Uninstall-ChocolateyZipPackage'.
VERBOSE: Exporting function 'Update-SessionEnvironment'.
VERBOSE: Exporting function 'Write-FunctionCallLogMessage'.
VERBOSE: Exporting function 'Install-ChocolateyDesktopLink'.
VERBOSE: Exporting function 'Write-ChocolateyFailure'.
VERBOSE: Exporting function 'Write-ChocolateySuccess'.
VERBOSE: Exporting function 'Write-FileUpdateLog'.
VERBOSE: Exporting function 'Get-AppInstallLocation'.
VERBOSE: Exporting function 'Get-AvailableDriveLetter'.
VERBOSE: Exporting function 'Get-EffectiveProxy'.
VERBOSE: Exporting function 'Get-PackageCacheLocation'.
VERBOSE: Exporting function 'Get-WebContent'.
VERBOSE: Exporting function 'Register-Application'.
VERBOSE: Exporting function 'Remove-Process'.
VERBOSE: Exporting function 'Install-DotNetDevPack'.
VERBOSE: Exporting function 'Install-DotNetFramework'.
VERBOSE: Exporting function 'Install-ChocolateyFont'.
VERBOSE: Exporting function 'Uninstall-ChocolateyFont'.
VERBOSE: Exporting function 'Install-WindowsUpdate'.
VERBOSE: Exporting function 'Test-WindowsUpdate'.
VERBOSE: Exporting alias 'Get-ProcessorBits'.
VERBOSE: Exporting alias 'Get-OSBitness'.
VERBOSE: Exporting alias 'Get-InstallRegistryKey'.
VERBOSE: Exporting alias 'Generate-BinFile'.
VERBOSE: Exporting alias 'Add-BinFile'.
VERBOSE: Exporting alias 'Start-ChocolateyProcess'.
VERBOSE: Exporting alias 'Invoke-ChocolateyProcess'.
VERBOSE: Exporting alias 'Remove-BinFile'.
VERBOSE: Exporting alias 'refreshenv'.
VERBOSE: Exporting alias 'Add-Font'.
VERBOSE: Exporting alias 'Remove-Font'.
VERBOSE: Importing function 'Format-FileSize'.
VERBOSE: Importing function 'Get-AppInstallLocation'.
VERBOSE: Importing function 'Get-AvailableDriveLetter'.
VERBOSE: Importing function 'Get-ChecksumValid'.
VERBOSE: Importing function 'Get-ChocolateyConfigValue'.
VERBOSE: Importing function 'Get-ChocolateyPath'.
VERBOSE: Importing function 'Get-ChocolateyUnzip'.
VERBOSE: Importing function 'Get-ChocolateyWebFile'.
VERBOSE: Importing function 'Get-EffectiveProxy'.
VERBOSE: Importing function 'Get-EnvironmentVariable'.
VERBOSE: Importing function 'Get-EnvironmentVariableNames'.
VERBOSE: Importing function 'Get-FtpFile'.
VERBOSE: Importing function 'Get-OSArchitectureWidth'.
VERBOSE: Importing function 'Get-PackageCacheLocation'.
VERBOSE: Importing function 'Get-PackageParameters'.
VERBOSE: Importing function 'Get-PackageParametersBuiltIn'.
VERBOSE: Importing function 'Get-ToolsLocation'.
VERBOSE: Importing function 'Get-UACEnabled'.
VERBOSE: Importing function 'Get-UninstallRegistryKey'.
VERBOSE: Importing function 'Get-VirusCheckValid'.
VERBOSE: Importing function 'Get-WebContent'.
VERBOSE: Importing function 'Get-WebFile'.
VERBOSE: Importing function 'Get-WebFileName'.
VERBOSE: Importing function 'Get-WebHeaders'.
VERBOSE: Importing function 'Install-BinFile'.
VERBOSE: Importing function 'Install-ChocolateyDesktopLink'.
VERBOSE: Importing function 'Install-ChocolateyEnvironmentVariable'.
VERBOSE: Importing function 'Install-ChocolateyExplorerMenuItem'.
VERBOSE: Importing function 'Install-ChocolateyFileAssociation'.
VERBOSE: Importing function 'Install-ChocolateyFont'.
VERBOSE: Importing function 'Install-ChocolateyInstallPackage'.
VERBOSE: Importing function 'Install-ChocolateyPackage'.
VERBOSE: Importing function 'Install-ChocolateyPath'.
VERBOSE: Importing function 'Install-ChocolateyPinnedTaskBarItem'.
VERBOSE: Importing function 'Install-ChocolateyPowershellCommand'.
VERBOSE: Importing function 'Install-ChocolateyShortcut'.
VERBOSE: Importing function 'Install-ChocolateyVsixPackage'.
VERBOSE: Importing function 'Install-ChocolateyZipPackage'.
VERBOSE: Importing function 'Install-DotNetDevPack'.
VERBOSE: Importing function 'Install-DotNetFramework'.
VERBOSE: Importing function 'Install-Vsix'.
VERBOSE: Importing function 'Install-WindowsUpdate'.
VERBOSE: Importing function 'Register-Application'.
VERBOSE: Importing function 'Remove-Process'.
VERBOSE: Importing function 'Set-EnvironmentVariable'.
VERBOSE: Importing function 'Set-PowerShellExitCode'.
VERBOSE: Importing function 'Start-ChocolateyProcessAsAdmin'.
VERBOSE: Importing function 'Test-ProcessAdminRights'.
VERBOSE: Importing function 'Test-WindowsUpdate'.
VERBOSE: Importing function 'Uninstall-BinFile'.
VERBOSE: Importing function 'Uninstall-ChocolateyEnvironmentVariable'.
VERBOSE: Importing function 'Uninstall-ChocolateyFont'.
VERBOSE: Importing function 'Uninstall-ChocolateyPackage'.
VERBOSE: Importing function 'Uninstall-ChocolateyZipPackage'.
VERBOSE: Importing function 'Update-SessionEnvironment'.
VERBOSE: Importing function 'Write-ChocolateyFailure'.
VERBOSE: Importing function 'Write-ChocolateySuccess'.
VERBOSE: Importing function 'Write-FileUpdateLog'.
VERBOSE: Importing function 'Write-FunctionCallLogMessage'.
VERBOSE: Importing alias 'Add-BinFile'.
VERBOSE: Importing alias 'Add-Font'.
VERBOSE: Importing alias 'Generate-BinFile'.
VERBOSE: Importing alias 'Get-InstallRegistryKey'.
VERBOSE: Importing alias 'Get-OSBitness'.
VERBOSE: Importing alias 'Get-ProcessorBits'.
VERBOSE: Importing alias 'Invoke-ChocolateyProcess'.
VERBOSE: Importing alias 'refreshenv'.
VERBOSE: Importing alias 'Remove-BinFile'.
VERBOSE: Importing alias 'Remove-Font'.
VERBOSE: Importing alias 'Start-ChocolateyProcess'.
---------------------------Script Execution---------------------------
Running 'ChocolateyScriptRunner' for zerotier-one v1.14.0.20240531 with packageScript 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\chocolateyinstall.ps1', packageFolder:'C:\ProgramData\chocolatey\lib\zerotier-one', installArguments: '', packageParameters: '', preRunHookScripts: '', postRunHookScripts: '',
Running package script 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\chocolateyinstall.ps1'
Running Install-ChocolateyInstallPackage -silentArgs '/qn /norestart /l*v "C:\Users\Matthew\AppData\Local\Temp\chocolatey\zerotier-one.1.14.0.20240531.log"' -file 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTierOne.msi' -fileType 'msi' -validExitCodes '0 3010' -packageName 'zerotier-one'
Running Get-OSArchitectureWidth -compare '32'
Installing zerotier-one...
Ensuring 'C:\Users\Matthew\AppData\Local\Temp\chocolatey' exists
Running Start-ChocolateyProcessAsAdmin -validExitCodes '0 3010' -workingDirectory 'C:\ProgramData\chocolatey\lib\zerotier-one\tools' -statements '/i "C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTierOne.msi" /qn /norestart /l*v "C:\Users\Matthew\AppData\Local\Temp\chocolatey\zerotier-one.1.14.0.20240531.log" ' -exeToRun 'C:\Windows\System32\msiexec.exe'
Test-ProcessAdminRights: returning True
Elevating permissions and running ["C:\Windows\System32\msiexec.exe" /i "C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTierOne.msi" /qn /norestart /l*v "C:\Users\Matthew\AppData\Local\Temp\chocolatey\zerotier-one.1.14.0.20240531.log" ]. This may take a while, depending on the statements.
Command ["C:\Windows\System32\msiexec.exe" /i "C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTierOne.msi" /qn /norestart /l*v "C:\Users\Matthew\AppData\Local\Temp\chocolatey\zerotier-one.1.14.0.20240531.log" ] exited with '0'.
Finishing 'Start-ChocolateyProcessAsAdmin'
zerotier-one has been installed.
----------------------------------------------------------------------
Built-in PowerShell host called with ['[System.Threading.Thread]::CurrentThread.CurrentCulture = '';[System.Threading.Thread]::CurrentThread.CurrentUICulture = '';[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::SystemDefault; & import-module -name 'C:\ProgramData\chocolatey\helpers\chocolateyInstaller.psm1'; & 'C:\ProgramData\chocolatey\helpers\chocolateyScriptRunner.ps1' -packageScript 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\chocolateyinstall.ps1' -installArguments '' -packageParameters '' -preRunHookScripts $null -postRunHookScripts $null'] exited with '0'.
Calling command ['"C:\Windows\System32\shutdown.exe" /a']
Command ['"C:\Windows\System32\shutdown.exe" /a'] exited with '1116'
zerotier-one may be able to be automatically uninstalled.
Environment Vars (like PATH) have changed. Close/reopen your shell to
see the changes (or in powershell/cmd.exe just type `refreshenv`).
Logging of values is not turned on by default because it
could potentially expose sensitive data. If you understand the risk,
please see `choco feature -h` for information to turn it on.
The following values have been added/changed (may contain sensitive data):
* path='[REDACTED]' (Machine)
Capturing package files in 'C:\ProgramData\chocolatey\lib\zerotier-one'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\zerotier-one.nupkg'
with checksum '4CAD4FBAA8A45866A2D2192407BF024C'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\zerotier-one.nuspec'
with checksum 'AFDB0B3FDA1B6FF3EC1918E7EDA9454F'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\legal\LICENSE.txt'
with checksum 'FAC5E752C563701DE2B3EB9F13C2BCC3'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\legal\VERIFICATION.txt'
with checksum 'EB630B2938D918CAD615072DAB53D4A1'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\chocolateyinstall.ps1'
with checksum '323DDB9A4BA6CBB999F4ED5AAA8021F3'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTierOne.msi'
with checksum '316FC65318BD86FD3B71593501825DE6'
Found 'C:\ProgramData\chocolatey\lib\zerotier-one\tools\ZeroTierOne.msi.ignore'
with checksum 'BEA07E6D2B8DCE396FE21BAA61B34956'
Attempting to create directory "C:\ProgramData\chocolatey\.chocolatey\zerotier-one.1.14.0.20240531".
There was no original file at 'C:\ProgramData\chocolatey\.chocolatey\zerotier-one.1.14.0.20240531\.registry'
There was no original file at 'C:\ProgramData\chocolatey\.chocolatey\zerotier-one.1.14.0.20240531\.files'
Attempting to delete file "C:\ProgramData\chocolatey\.chocolatey\zerotier-one.1.14.0.20240531\.extra".
Attempting to delete file "C:\ProgramData\chocolatey\.chocolatey\zerotier-one.1.14.0.20240531\.version".
Attempting to delete file "C:\ProgramData\chocolatey\.chocolatey\zerotier-one.1.14.0.20240531\.sxs".
Attempting to delete file "C:\ProgramData\chocolatey\.chocolatey\zerotier-one.1.14.0.20240531\.pin".
Attempting to delete directory "C:\ProgramData\chocolatey\lib-bad\zerotier-one".
Sending message 'HandlePackageResultCompletedMessage' out if there are subscribers...
Attempting to delete file "C:\ProgramData\chocolatey\lib\zerotier-one\.chocolateyPending".
Attempting to delete directory "C:\ProgramData\chocolatey\lib-bkp\zerotier-one".
The install of zerotier-one was successful.
Software installed to 'C:\Program Files (x86)\ZeroTier\One\'

Chocolatey installed 1/1 packages.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Did you know the proceeds of Pro (and some proceeds from other
licensed editions) go into bettering the community infrastructure?
Your support ensures an active community, keeps Chocolatey tip-top,
plus it nets you some awesome features!
https://chocolatey.org/compare
Sending message 'PostRunMessage' out if there are subscribers...
Exiting with 0

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@drfuzzyness
[ZeroTier-One] Correct installer name inconsistency
68f6207 
Resolves #240 by correcting the installer name inconsistency with
the URL. Official ZeroTier One distros now include an installer with no
spaces in the name: `ZeroTierOne.msi` so the URL encoding issue can be
resolved by simply not using a space in the name.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

mkevenaar
mkevenaar approved these changes Jun 1, 2024
View reviewed changes
Copy link
Owner

@mkevenaar mkevenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkevenaar mkevenaar merged commit 39ad933 into mkevenaar:master Jun 1, 2024
2 checks passed
@mkevenaar
Copy link
Owner

@drfuzzyness your changes have been merged, thank you for your contribution!

@BinToss
Copy link

BinToss commented Jul 22, 2024

Chocolatey clients are still pulling the original, broken 1.14.0 package. That package version may need to be delisted for the autoupdater to push the replacement. I'm not sure how the autoupdater will handle the replacement's versioning. Will it append a version suffix to denote the revision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevenaar mkevenaar mkevenaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZeroTier-One Chocolatey package fails
4 participants
@drfuzzyness @AppVeyorBot @mkevenaar @BinToss