Optional Embed Input #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arl1nd Thanks! |
|
Sure, just a minute. Thanks for prompt reply. |
|
@arl1nd I released it! You can upgrade version to 3.0.0. |
|
@avdeev thanks a lot! I really appreciate your consideration to add this patch. Have a great weekend! |
OliDM
pushed a commit
to OliDM/videojs-share
that referenced
this pull request
Feb 25, 2019
* If there is no embed markup, do not show the field. * Make embedContainer optional, if there is no markup do not display the field * Added embedCode to readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make embedContainer optional, if there is no markup do not display the field