Skip to content

Commit

Permalink
feat(ui): metadata.annotations: too long message Improved (argoproj#1…
Browse files Browse the repository at this point in the history
…7452)

* metadata.annotations: too long

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

* added as a default case

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>

---------

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
  • Loading branch information
surajyadav1108 authored and mkieweg committed Jun 11, 2024
1 parent dc6e7f6 commit d3ab14c
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions util/argo/argo.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ func AugmentSyncMsg(res common.ResourceSyncResult, apiResourceInfoGetter func()
} else {
res.Message = fmt.Sprintf("The Kubernetes API could not find version %q of %s/%s for requested resource %s/%s. Version %q of %s/%s is installed on the destination cluster.", res.Version, res.ResourceKey.Group, res.ResourceKey.Kind, res.ResourceKey.Namespace, res.ResourceKey.Name, resource.GroupVersionResource.Version, resource.GroupKind.Group, resource.GroupKind.Kind)
}

default:
// Check if the message contains "metadata.annotation: Too long"
if strings.Contains(res.Message, "metadata.annotations: Too long: must have at most 262144 bytes") {
res.Message = fmt.Sprintf("%s \n -Additional Info: This error usually means that you are trying to add a large resource on client side. Consider using Server-side apply or syncing with replace enabled. Note: Syncing with Replace enabled is potentially destructive as it may cause resource deletion and re-creation.", res.Message)
}
}

return res.Message, nil
Expand Down

0 comments on commit d3ab14c

Please sign in to comment.