Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple KNX Interfaces. #124

Closed
wants to merge 5 commits into from
Closed

Support for multiple KNX Interfaces. #124

wants to merge 5 commits into from

Conversation

encbladexp
Copy link

This pull request enables support for multiple KNX interfaces per smarthome instance. The existing behavior is not changed.

Missing things:

  • Documentation
  • Item Inheritance (use same KNX Interface on a tree of KNX items)

@ohinckel
Copy link

ohinckel commented Jul 2, 2014

I have implemented a similar feature to support registration of plugins (not only the KNX plugin) multiple times in the plugin confiugration. My implementation consists of two new features:

To summarize this you can configure the plugins (in plugin.conf) and the items (in items.conf) using the following:

[knx1]
  class_name = KNX
  class_path = plugins.knx
  host = 192.168.X.Y
  ...
[knx2]
  class_name = KNX
  class_path = plugins.knx
  host = 192.168.X.Z
  ...
  [knx1]
    [[item1]]
      plugin = knx1
      ...
  [knx2]
    [[item1]]
      plugin = knx2
      ...

Both is currently not merged, since it touch also the core of SmartHome.py. Maybe this pull request shows that other plugins also need support to be registered multiple times and a more generic implementation would help plugin developers a lot to support this (see pull request #81, which is using this already for the SML plugin).

@encbladexp
Copy link
Author

I will port my changes if your pull request gets merged.

@encbladexp
Copy link
Author

Rebased on current develop...

@encbladexp
Copy link
Author

Rebased another Time. Is there any chance of getting this PR applied?

@cstrassburg
Copy link

@encbladexp encbladexp closed this Apr 24, 2016
@ohinckel
Copy link

@cstrassburg I just created a new PR smarthomeNG/smarthome#50 which means, that this PR can be changed in that way that is will use the plugin methods introduced by the smarthomeNG/smarthome#50.

Do you merged the stuff to smarthomeNG already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants