Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for gradient progress indicator #30

Merged
merged 8 commits into from
Oct 18, 2023
Merged

feat: support for gradient progress indicator #30

merged 8 commits into from
Oct 18, 2023

Conversation

PranavMasekar
Copy link
Contributor

Status

IN DEVELOPMENT

Description

Provides option to add gradient progress indicator or solid progress indicator.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@PranavMasekar PranavMasekar mentioned this pull request Oct 17, 2023
Closed
@mkobuolys mkobuolys changed the title Gradient and Solid Progress Indicator feat: support for gradient linear progress indicator Oct 17, 2023
@mkobuolys mkobuolys changed the title feat: support for gradient linear progress indicator feat: support for gradient progress indicator Oct 17, 2023
mkobuolys
mkobuolys reviewed Oct 17, 2023
View reviewed changes
example/lib/main.dart Outdated Show resolved Hide resolved
mkobuolys
mkobuolys requested changes Oct 17, 2023
View reviewed changes
Copy link
Owner

@mkobuolys mkobuolys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress so far, just do not forget to update the README.md where needed.

@PranavMasekar
Copy link
Contributor Author

Nice progress so far, just do not forget to update the README.md where needed.

Yes I will first do the recommanded changes

mkobuolys
mkobuolys requested changes Oct 18, 2023
View reviewed changes
Copy link
Owner

@mkobuolys mkobuolys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To-do items:

  1. Update slide configuration to support progress indicator overrides
  2. Update README.md where needed
  3. Update CHANGELOG.md to prepare this PR for the upcoming release

mkobuolys
mkobuolys requested changes Oct 18, 2023
View reviewed changes
Copy link
Owner

@mkobuolys mkobuolys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and fix all the open comments in the PR.

@PranavMasekar
Copy link
Contributor Author

I haven't updated CHANGELOG.md yet

@mkobuolys mkobuolys merged commit e9898e9 into mkobuolys:main Oct 18, 2023
2 of 3 checks passed
@mkobuolys
Copy link
Owner

mkobuolys commented Oct 18, 2023 •
edited
Loading

I haven't updated CHANGELOG.md yet

Ah, didn't notice. I will update it myself, no worries.

@PranavMasekar
Copy link
Contributor Author

I haven't updated CHANGELOG.md yet

Ah, didn't notice. I will update it myself, no worries.

Sure Thanks :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkobuolys mkobuolys mkobuolys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PranavMasekar @mkobuolys