Installation of ungoogled-chromium with "-appDir" parameter fails

[engelhro]

Hello,

This issue seems to be related to issue #13 I created before.

When using the -appDir parameter to install the browser into the %AppData% directory (i.e., the respective subfolder), the script has problems as editor is used with both meanings "author" (person who provides a browser build) and "name" (browser variant to be used).

I tried to install the ungoogled-chromium variant, by calling the script as follows:

chrupd.cmd -appDir -editor Ungoogled -arch 64bit -channel stable

This results in the following output:

[...]
ERROR: Shortcut target "C:\Users\<Username>\Desktop\Marmaduke\chrome.exe" does not exist
ERROR: Could not create shortcut on Desktop
[OK] Done. New Chromium version extracted to "C:\Users\<Username>\Desktop\Marmaduke".

So the editor "Marmaduke" (person) is used here, where probably the term "Ungoogled" (name) should've been used instead (to avoid confusion).

But:

1. The installation should have happened to %AppData%, not the desktop?

2. The actual installation was done to a folder on the desktop called ungoogled-chromium-<version>, not "Marmaduke", as the script output implies.

So apparently neither the "editor" (as person, i.e. "Marmaduke") nor the "name" (as variant, i.e. just "Ungoogled") interpretation were considered completely correct. Is this intended?

The help suggests otherwise… It mentions a parameter $editor which clearly should've resulted in one of the both interpretations above.

And of course the browser should've landed in the %AppData% folder, not on the desktop.

[mkorthof]

Thanks for the detailed report, I'll look into it.
Folder could be right, see /docs/Archives.md

[mkorthof]

Fixed in latest commit. If you use v20210109 or newer script will autoupdate