do not require Content Security Policy (CSP) style-src 'unsafe-inline' #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
added a commit
to jelhan/croodle
that referenced
this pull request
Aug 13, 2016
Could get rid of `style-src: 'unsafe-inline'` after mkoryak/floatThead#321 has been merged and made it's way in a new release. Part of #90
|
I think this is also much cleaner JS/jQuery code. 👍 |
| } | ||
|
|
||
| cols = cols.join(''); | ||
| cells = cells.join(''); | ||
|
|
||
| if(createElements){ | ||
| psuedo = psuedo.join(''); | ||
| $fthRow.html(psuedo); | ||
| $fthRow.append(psuedo); |
There was a problem hiding this comment.
is appending an array actually any faster than html which i assume uses innerHTML?
I am optimizing for speed vs clarity in most cases here.
There was a problem hiding this comment.
.html('<div style="width: 100%"></div>') violates CSP 'unsafe-inline'. Therefore refactored to append an array of jQuery elements. Didn't considered performance.
Edit: Note that content of psuedo array is changed from string to jQuery Objects a few lines above in this PR.
|
Thanks! |
|
@mkoryak Do you mind to release a patch version? |
|
I don't normally release with so little changes, but since you took time to make a PR, here is your new version: |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not trigger a Content Security Policy (CSP) 'unsafe-inline' violation we have to modify CSSOM directly. This is what jQuery
.css()method does. Therefore code like$('<div style="width: 100"');should be avoided to not force consuming applications to lower CSP rules.