Fix rsa openssl mismatch #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 14, 2012 10:09
With this patch we can now do things like verify a x509 cert against a x509_ca
then extract its pubkey and test a message signature.
cert = crypto.x509_cert()
cert:from_pem(server_cert)
kpub = cert:pubkey()
message = 'Hello world'
verified = crypto.verify('md5', message, signature, kpub)
add docs for the x509_cert and x509_ca objects.
Detect what type of key we are dealing with and use the right to_pem function. This way we match the enconding that the openssl dsa|rsa apps use for certificates.
check the return codes of wrote_bio_PrivateKey for any error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to compare the output of openssl rsa|dsa in unit tests to the to_pem functions and found a couple of bugs. They were detected when linking luacrypto to certain versions of openssl by the existing unit tests.