Add matching title as the -t option #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use case: I use Chromium feature to open Gmail webpage as an application window. Then I bind a hotkey to focus directly the Gmail window (and not other Chromium windows) or open it if it's closed: jumpapp -t "Mail" chromium-browser --app=https://mail.google.com/mail/u/0 Then I bind another hotkey to cycle other Chromium windows or open Chromium if it's closed: jumpapp -t Chromium chromium-browser --ssl-version-min=tls1 I use this feature a lot since months so I though you might want to make it accessible for everyone.
|
Thanks for the PR! Matching on the title makes a lot of sense. I won't be able to test your changes for a few days, but when I'm able I'll test it out and get this merged in. |
mkropat
added a commit
that referenced
this pull request
Sep 26, 2015
|
Merged to master with f60a0b6. I rebased your commits together, added unit tests, and refactored the code a bit. Thanks for you patience. When you get a chance, can you pull down the latest |
|
Master's working, cool, thanks a lot ;) |
|
Perfect. Thanks for confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
I use Chromium feature to open Gmail webpage as an application window. Then I bind a hotkey to focus directly the Gmail window (and not other Chromium windows) or open it if it's closed:
jumpapp -t "Mail" chromium-browser --app=https://mail.google.com/mail/u/0Then I bind another hotkey to cycle other Chromium windows or open Chromium if it's closed:
jumpapp -t Chromium chromium-browser --ssl-version-min=tls1I use this feature a lot since months so I though you might want to make it accessible for everyone.