-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat Card Update #124
Chat Card Update #124
Conversation
Oop, I need to reroll this, my fork was out of date. |
bd072ad
to
093844b
Compare
Conflicts have been resolved, but there are some issues that need to be resolved before merge should proceed.
|
I have done some preliminary testing on this today, the 1E rolls look great compared to how they did. The focus, item, talent cards also much tidier. The only thing I am a little ambivalent on is the 2e weapons having (2E) after them, not sure if they need that, but open to being convinced on it. The hide & unhide seems to work reliably. |
Yeah, maybe explicitly identifying the edition doesn't really matter, since players won't really care and there's no harm in them both just being called "Character Weapon" |
Conflicts caused in the reroll listeners have been resolved, and "2E" is no longer included in those strings. |
Collabed with @tokeidlom on handling #125 and rolled into this. Looks like I need to potentially reroll all of this after a dev branch update. |
Moving display concerns into hbs is a first step towards completion of mkscho63#117. Large swaths of JavaScript HTML strings now reside in files intended for the purpose of generating HTML.
Challenge rolls generate cards by wrapping a div around the partial handlebar template for challenge rolls, which are otherwise embedded in item rolls.
Challenge rolls generate cards by wrapping a div around the partial handlebar template for challenge rolls, which are otherwise embedded in item rolls.
This allows us to better access items during card actions, and is a little less fragile than searching for HTML elements. This also fixes an issue with inconsistent speakers between rerolls on a challenge.
…rds. Also, as a result, fixes an issue with inconsistent "speaker" in chat cards during rerolls.
Clarifies developer intent, allows tools to auto recognize file type.
These titles for individual items were not visible previously, but new card design for mkscho63#117 required them.
The dice-tooltip behavior from Foundry was a little clunky, and jarring next to the more reliable implementation on descriptions.
…bedded info. Made performChallengeRoll's speaker argument optional (as well as in subsequent steps), allowing the system to naturally fill in the gaps.
Indents corrected, single quotes used, and parens around arrow function arguments (see Eslint rules).
Wrong quotes and missing parens in arrow functions (eslint checks).
f96bcc2
to
1ccbf24
Compare
Reroll finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thank you
Re: #117
Here are some notes related to this PR.
Chat Card Update
Chat cards generated by clicking on buttons in character sheets generate cards that look and behave little bit nicer, and contain more information.
Behind the scenes:
hbs
; this makes the intent of the files more clear at a glance and can also trigger IDE tooling and assistance easier, improving the developer experience.Tested in the Windows version of foundry. Foundry v10, v11, and v12.