Refactor: Persistence clean-up #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Renamed DataSource.kt to ListDataSource, because that's what it is. Also made it inherit from DataSource. fix: Removed "shared" in the naming, because that might confuse these with using actual SharedPreferences. fix: Renamed the member-functions from get/add/getAll/addAll to load/save/add, and made the behavior consistent between list- and single-. fix: Simplified add.
chnt
changed the title
levinzonr
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistency in name and function.
fix: Renamed DataSource.kt to ListDataSource, because that's what it is. Also made it inherit from DataSource.
fix: Removed "shared" in the naming, because that might confuse these with using actual SharedPreferences.
fix: Renamed the member-functions from get/add/getAll/addAll to load/save/add, and made the behavior consistent between list- and single-.
fix: Simplified add().
fix: Better clear() - actually remove stuff, not just overwrite with empty string.
feat: Added Javadoc, even though the naming should be quite self-explanatory