This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Stateful LSTM #67
Merged
Stateful LSTM #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvalenzuela
reviewed
Oct 9, 2018
There was a problem hiding this comment.
This is super clear! Maybe @shiffman has more inputs for the examples? Is there a more friendly version of slicing a string in p5? (generate(currentText.slice(-1), true);)
|
|
||
| // start autogenerating | ||
| function onStartButton() { | ||
| if(currentText == '') generateWithFullInputText(); |
There was a problem hiding this comment.
Just a style comment: we writing if/else statements with { } instead of inline.
| // Generate new text | ||
| function generate(seed, stateful) { | ||
| // prevent starting inference if we've already started another instance | ||
| // TODO: is there better JS way of doing this? |
There was a problem hiding this comment.
We can also handle this from the src. Adding await tf.nextFrame(); in generateInternal() will wait for tf before computing another pass
joeyklee
pushed a commit
that referenced
this pull request
Nov 7, 2019
* first example to test lstm updates * add runningInference check to LSTM examples to avoid running model simultaneously multiple times * added basic working Stateful LSTM example * remove LSTM Text Mixer example * fix LSTM stateful example if else code style * LSTM stateful example visualises probability distributions * adding new model and feaute extractor example * updates to new api
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to the LSTM examples to make compatible with the PR for stateful LSTM. Also, an example for stateful LSTM.