Docs: Convert to LSTM example to vanilla JS, add description #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also move the |
Closed
|
awesome! should we merge? |
|
Yes! (My "review approved" checkmark was meant to be confirmation of this!) |
joeyklee
pushed a commit
that referenced
this pull request
Jun 2, 2019
Docs: Convert to LSTM example to vanilla JS, add description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes p5 as a dependency for the simple LSTM example, relying instead on vanilla JS DOM calls. It also removes
noCanvas()from the original example code as documented; while this is necessary for it to run in the documentation framework itself, for an individual user copying and pasting the demo code it will simply throw an error.I also added a prose description of what the demo is doing.