Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS Safari doesn't delegate click events.. only touch events #340

Closed
mlaursen opened this issue Apr 19, 2017 · 0 comments
Closed

iOS Safari doesn't delegate click events.. only touch events #340

mlaursen opened this issue Apr 19, 2017 · 0 comments
Labels
bug
Milestone
v1.0.12

Comments

@mlaursen
Copy link
Owner

mlaursen commented Apr 19, 2017 •
edited
Loading

Everywhere I used a window.addEventListener('click', ...do something); don't really work on iOS mobile safari because of this.

This can be solved by adding body { cursor: pointer } on safari, adding an invisible overlay that should be clicked (might cause issues), also update to include touchend, or add a no-op function on the react root div.
@mlaursen mlaursen added the bug label Apr 19, 2017
@mlaursen mlaursen changed the title iOS Safari doesn't bubble click events.. only touch events iOS Safari doesn't delegate click events.. only touch events Apr 20, 2017
@mlaursen mlaursen added this to the v1.0.12 milestone Apr 20, 2017
mlaursen added a commit that referenced this issue Apr 20, 2017
@mlaursen
Fixed Mobile Safari Click Delegation Issue
e3a9153 
All the components that relied on being closed with an outside click did
not work on mobile safari. I ended up going with a cheap solution of
just updating the <body> to have a pointer cursor on mobile safari so
the event is delegated correctly.

Closes #340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.0.12
Development

No branches or pull requests
1 participant
@mlaursen