Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectField Incorrectly Sets error state when required #353

Closed
mlaursen opened this issue Apr 30, 2017 · 0 comments
Closed

SelectField Incorrectly Sets error state when required #353

mlaursen opened this issue Apr 30, 2017 · 0 comments
Labels
bug
Milestone
v1.0.13

Comments

@mlaursen
Copy link
Owner

The error state currently gets updated in componentWillUpdate when the required prop is enabled. So when you inline your menuItems, the error state will be triggered if there is no defaultValue.

This should really only happen after initial focus.
@mlaursen mlaursen added the bug label Apr 30, 2017
@mlaursen mlaursen added this to the v1.0.13 milestone Apr 30, 2017
mlaursen added a commit that referenced this issue Apr 30, 2017
@mlaursen
Fixed the SelectField Error State
0e33e11 
Closees #353
@mlaursen mlaursen closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.0.13
Development

No branches or pull requests
1 participant
@mlaursen