Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] - Adding the 'md-title--toolbar' class name to the Autocomplete breaks the styling of Avatars #375

Closed
fabiozaffani opened this issue May 20, 2017 · 0 comments
Closed

[Autocomplete] - Adding the 'md-title--toolbar' class name to the Autocomplete breaks the styling of Avatars #375

fabiozaffani opened this issue May 20, 2017 · 0 comments
Labels
bug
Milestone
v1.1.3

Comments

@fabiozaffani
Copy link

This happens because of the line-height attribute of 64px that md-title--tolbar class apply (in a desktop situation), since the class ".md-list-tile--avatar" doesn't specify a line-height (only a height) it will inherit the line-height from "md-title--toolbar" whici will break both the Avatar position in the List component and also it's inner image position

Version

  • React 15.4.2
  • React-MD 1.0.14
@mlaursen mlaursen added the bug label May 22, 2017
@mlaursen mlaursen changed the title Applying "md-title--toolbar" in an Autocomplete div wrapper breaks Avatar image alignment [Autocomplete] - Adding the 'md-title--toolbar' class name to the Autocomplete breaks the styling of Avatars Jul 14, 2017
@mlaursen mlaursen added this to the v1.1.3 milestone Sep 15, 2017
mlaursen added a commit that referenced this issue Sep 15, 2017
@mlaursen
Fixed ListItem's Addon line-height
0b6a45b 
When a different line-height was applied to a parent component of a
Menu's List, the icons and avatars would be displayed incorrectly since
it inherited the line-height from the parent. This patch adds a specific
line-heigh to the addons to prevent this.

Closes #375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.1.3
Development

No branches or pull requests
2 participants
@fabiozaffani @mlaursen