Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SelectFields] - Disabling ink on a SelectField item completely breaks keyboard functionality #666

Closed
mlaursen opened this issue Jan 9, 2018 · 0 comments
Closed

[SelectFields] - Disabling ink on a SelectField item completely breaks keyboard functionality #666

mlaursen opened this issue Jan 9, 2018 · 0 comments
Labels
bug
Milestone
v1.2.11

Comments

@mlaursen
Copy link
Owner

mlaursen commented Jan 9, 2018 •
edited

Description

Disabling ink via context or props will break the ability to select items in a SelectField with the keyboard.

Link to a gist or code sample where the issue can be reproduced

https://codepen.io/mlaursen03/pen/EoQdpR

Version

  • React - .
  • React-MD - <= 1.2.10
@mlaursen mlaursen added the bug label Jan 9, 2018
@mlaursen mlaursen added this to the v1.2.11 milestone Jan 9, 2018
mlaursen added a commit that referenced this issue Jan 9, 2018
@mlaursen
Fixed focus for inked components
f47bf22 
Updated the injectInk HOC so that it will still correctly focus itself
if the ink is disabled.

Closes #666  #EVILLLL
@mlaursen mlaursen mentioned this issue Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.2.11
Development

No branches or pull requests
1 participant
@mlaursen