Pitch display #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing the data from the API seems to work. Need to figure out the actual pitch location, and how to display this nicely within a tui-rs canvas.
Doesn't look great right now..
Layouts are super jank right now and the pitch location isn't correct yet. But, it's a start.
Fixes issue #5
Before the big layout refactor
Also displaying the team name in the box score now
Also added inning information
This was referenced May 21, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the initial pitch display to the Gameday tab. Seems to be working well, except the locations. When I refactor all of the layout code I will revisit this.
changed the heat map to display Rectangles on a Canvas, instead of using a Table. I think it looks better (less bright) but I still might fill them in. This closes issue Dynamically sized heatmap #3 since it's not relevant anymore - the canvas automatically resizes.
fixed issue rename GameDay to Gameday #5