Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Message] Update error messages to be more detailed #413

Merged
merged 1 commit into from
May 22, 2024

Conversation

Neet-Nestor
Copy link
Contributor

@Neet-Nestor Neet-Nestor commented May 22, 2024

This PR updates error messages in engine.ts to ensure they are clear, intuitive, and more detailed.

Copy link
Contributor

@CharlieFRuan CharlieFRuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@CharlieFRuan CharlieFRuan merged commit 67f9219 into mlc-ai:main May 22, 2024
1 check passed
@Neet-Nestor Neet-Nestor deleted the error_message branch May 22, 2024 23:06
CharlieFRuan added a commit that referenced this pull request May 22, 2024
### Changes
The only two changes are:

- #413
- #415
- Fixes `index.js.map` issue in Vite reported in
#414

### WASM Version
v0_2_34 as no change is required.

### TVMjs
TVMjs compiled at
apache/tvm@a5862a5,
with no change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants