Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Vite] Fix error for index.js.map #415

Merged
merged 1 commit into from
May 22, 2024

Conversation

CharlieFRuan
Copy link
Contributor

Address issue #414. Since index.js.map is a json, when specifying string, we should use \" instead of ".

Prior to this PR, we populate const performanceNode = "MLC_DUMMY_REQUIRE_VAR", this PR changes it to const performanceNode = \"MLC_DUMMY_REQUIRE_VAR\"

@CharlieFRuan CharlieFRuan merged commit 7783e5a into mlc-ai:main May 22, 2024
1 check passed
CharlieFRuan added a commit that referenced this pull request May 22, 2024
### Changes
The only two changes are:

- #413
- #415
- Fixes `index.js.map` issue in Vite reported in
#414

### WASM Version
v0_2_34 as no change is required.

### TVMjs
TVMjs compiled at
apache/tvm@a5862a5,
with no change
tqchen pushed a commit that referenced this pull request May 25, 2024
- Follow-up from #415
- Fixes #414

This PR escapes the `MLC_DUMMY_PATH` variable the same way it was done
with `MLC_DUMMY_REQUIRE_VAR` in #415.

P.S. I edited the file directly in GitHub UI, and it automatically added
a line break in the last line of the file. It was not intentional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant