Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routers refacto #189

Merged
merged 6 commits into from
Jun 23, 2021
Merged

Routers refacto #189

merged 6 commits into from
Jun 23, 2021

Conversation

SaboniAmine
Copy link
Collaborator

Emissions / Experiments / Projects refacto :

  • db, repository and service are injected into a container
  • Starting from a DataForGood Team, Projects -> Experiments -> Run creation (with manual id chaining) is now valid. Should the API create default values if the users does not references correct ids ? Should part of this logic be handled in the package ?

@SaboniAmine
Copy link
Collaborator Author

Default values would be handled in a following PR (out of this one's scope as discussed with Benoit)

@SaboniAmine SaboniAmine merged commit 5c4f9e1 into master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit-cty benoit-cty benoit-cty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaboniAmine @benoit-cty @SabAmine