Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated post-training model optimization to ensure the built-in parameters can be used #672

Closed
sarthakpati opened this issue Jun 8, 2023 · 0 comments · Fixed by #673
Closed

Updated post-training model optimization to ensure the built-in parameters can be used #672

sarthakpati opened this issue Jun 8, 2023 · 0 comments · Fixed by #673
Assignees
@sarthakpati
Labels
enhancement New feature or request

Comments

@sarthakpati
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Following up on #671, it would make sense for the optimization step to use the built-in parameters instead of having to pass a different config.

Describe the solution you'd like
N.A.

Describe alternatives you've considered
N.A.

Additional context
N.A.
@sarthakpati sarthakpati self-assigned this Jun 8, 2023
@sarthakpati sarthakpati added the enhancement New feature or request label Jun 8, 2023
sarthakpati added a commit to sarthakpati/GaNDLF that referenced this issue Jun 8, 2023
@sarthakpati
prioritizing built-in parameters instead of the one passed in cli mlc…
6b376e6 
…ommons#672
@sarthakpati sarthakpati mentioned this issue Jun 8, 2023
Merged
11 tasks
@sarthakpati sarthakpati linked a pull request Jun 8, 2023 that will close this issue
Ensure parameters are built into the model dictionary #673
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarthakpati sarthakpati

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure parameters are built into the model dictionary sarthakpati/GaNDLF
1 participant
@sarthakpati