Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure parameters are built into the model dictionary #673

Merged
merged 11 commits into from
Jun 11, 2023

Conversation

sarthakpati
Copy link
Collaborator

Fixes #671 #672

Proposed Changes

  • bundle parameters with model dict
  • updated post-training optimization code with this logic

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • History has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati marked this pull request as draft June 8, 2023 19:53
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #673 (1eb2967) into master (6f00a4e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   94.43%   94.42%   -0.01%     
==========================================
  Files         115      115              
  Lines        7872     7879       +7     
==========================================
+ Hits         7434     7440       +6     
- Misses        438      439       +1     
Flag Coverage Δ
unittests 94.42% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/cli/post_training_model_optimization.py 100.00% <100.00%> (ø)
GANDLF/utils/generic.py 88.50% <100.00%> (+0.13%) ⬆️
GANDLF/utils/modelio.py 82.55% <100.00%> (+0.41%) ⬆️
testing/test_full.py 99.14% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarthakpati sarthakpati marked this pull request as ready for review June 9, 2023 19:43
@Geeks-Sid Geeks-Sid merged commit e38b076 into mlcommons:master Jun 11, 2023
15 of 16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2023
@sarthakpati sarthakpati deleted the fix_671_672 branch June 11, 2023 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants