Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in parameters for gandlf_collectStats #321

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

dlang95
Copy link
Contributor

@dlang95 dlang95 commented Feb 27, 2022

Change
inputDir = os.path.normpath(args.inputDir) to:
inputDir = os.path.normpath(args.modelDir) to match actual args (no inputDir argument)

  • Fixes argument parsing to allow for proper usage

Checklist

  • [X ] I have read the CONTRIBUTING guide
  • [ X] My PR is based from the current GaNDLF master
  • [X ] Non-breaking change (would not break existing functionality): please provide as many details as possible for any breaking change
  • [ X] Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation

Change     
inputDir = os.path.normpath(args.inputDir) to:
inputDir = os.path.normpath(args.modelDir) to match actual args (no inputDir argument)
@sarthakpati sarthakpati self-requested a review February 28, 2022 00:25
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarthakpati sarthakpati changed the title Update gandlf_collectStats Bug fix in parameters for gandlf_collectStats Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #321 (a5f1334) into master (61af13f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          85       85           
  Lines        4418     4418           
=======================================
  Hits         3914     3914           
  Misses        504      504           
Flag Coverage Δ
unittests 88.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b074998...a5f1334. Read the comment docs.

@sarthakpati sarthakpati merged commit 8171cc8 into mlcommons:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants