Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling inference without having access to the ground truth #363

Merged
merged 13 commits into from
Mar 22, 2022

Conversation

sarthakpati
Copy link
Collaborator

Fixes #360

Proposed Changes

  • added logic to not require ground truth during inference

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (would not break existing functionality): please provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #363 (cd0e82b) into master (25f05dd) will increase coverage by 0.30%.
The diff coverage is 96.80%.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   90.92%   91.23%   +0.30%     
==========================================
  Files          89       89              
  Lines        5016     5052      +36     
==========================================
+ Hits         4561     4609      +48     
+ Misses        455      443      -12     
Flag Coverage Δ
unittests 91.23% <96.80%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/utils/__init__.py 100.00% <ø> (ø)
GANDLF/compute/forward_pass.py 89.40% <94.33%> (+4.85%) ⬆️
GANDLF/compute/step.py 78.26% <100.00%> (+2.07%) ⬆️
GANDLF/inference_manager.py 98.03% <100.00%> (+4.28%) ⬆️
GANDLF/utils/generic.py 83.72% <100.00%> (+1.22%) ⬆️
testing/test_full.py 98.42% <100.00%> (+0.03%) ⬆️
GANDLF/metrics/segmentation.py 95.71% <0.00%> (-1.43%) ⬇️
GANDLF/data/ImagesFromDataFrame.py 89.36% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f05dd...cd0e82b. Read the comment docs.

@sarthakpati sarthakpati marked this pull request as ready for review March 22, 2022 20:28
@sarthakpati sarthakpati changed the title Enabling inference with ground truth Enabling inference without having access to the ground truth Mar 22, 2022
@Geeks-Sid Geeks-Sid merged commit 2ae23ff into mlcommons:master Mar 22, 2022
@sarthakpati sarthakpati deleted the 360_inference_without_labels branch March 22, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inference of classification task on unseen data
2 participants