-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved penalty calculation and added ImageNet-specific VGG #365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 91.57% 91.54% -0.03%
==========================================
Files 92 93 +1
Lines 5316 5394 +78
==========================================
+ Hits 4868 4938 +70
- Misses 448 456 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@sarthakpati Can you check why the CI is failing, i think it is an issue with the data in itself where one of the columns is named wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Fixing tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #ISSUE_NUMBER
Proposed Changes
Checklist
CONTRIBUTING
guidepip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]