Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved penalty calculation and added ImageNet-specific VGG #365

Merged
merged 47 commits into from
Mar 29, 2022

Conversation

Geeks-Sid
Copy link
Collaborator

Fixes #ISSUE_NUMBER

Proposed Changes

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (would not break existing functionality): please provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #365 (a047ef8) into master (0301b91) will decrease coverage by 0.02%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   91.57%   91.54%   -0.03%     
==========================================
  Files          92       93       +1     
  Lines        5316     5394      +78     
==========================================
+ Hits         4868     4938      +70     
- Misses        448      456       +8     
Flag Coverage Δ
unittests 91.54% <88.46%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/data/ImagesFromDataFrame.py 88.88% <ø> (+0.81%) ⬆️
GANDLF/utils/__init__.py 100.00% <ø> (ø)
GANDLF/utils/parameter_processing.py 91.48% <ø> (ø)
GANDLF/models/imagenet.py 70.00% <70.00%> (ø)
GANDLF/compute/training_loop.py 83.88% <100.00%> (+0.90%) ⬆️
GANDLF/losses/regression.py 92.04% <100.00%> (-0.09%) ⬇️
GANDLF/models/__init__.py 100.00% <100.00%> (ø)
GANDLF/utils/tensor.py 81.37% <100.00%> (+1.68%) ⬆️
testing/test_full.py 98.26% <100.00%> (+0.03%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0301b91...a047ef8. Read the comment docs.

@Geeks-Sid Geeks-Sid marked this pull request as ready for review March 23, 2022 22:35
GANDLF/compute/training_loop.py Outdated Show resolved Hide resolved
GANDLF/compute/training_loop.py Outdated Show resolved Hide resolved
GANDLF/compute/training_loop.py Show resolved Hide resolved
GANDLF/utils/tensor.py Outdated Show resolved Hide resolved
testing/test_full.py Show resolved Hide resolved
testing/test_full.py Outdated Show resolved Hide resolved
GANDLF/utils/tensor.py Outdated Show resolved Hide resolved
@Geeks-Sid
Copy link
Collaborator Author

@sarthakpati Can you check why the CI is failing, i think it is an issue with the data in itself where one of the columns is named wrong.

sarthakpati
sarthakpati previously approved these changes Mar 25, 2022
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarthakpati sarthakpati changed the title Improved penalty calculation and imagenet vgg Improved penalty calculation and added ImageNet-specific VGG Mar 29, 2022
@Geeks-Sid Geeks-Sid merged commit e504164 into mlcommons:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants