Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify testing data csv in main cli #545

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Jan 20, 2023

Fixes #544

Proposed Changes

  • API for TrainingManager_split updated to include testing data
  • new api is being used in main_run

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati marked this pull request as draft January 20, 2023 01:19
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #545 (30b1f04) into master (8aeed76) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #545   +/-   ##
=======================================
  Coverage   93.89%   93.90%           
=======================================
  Files         109      109           
  Lines        6943     6951    +8     
=======================================
+ Hits         6519     6527    +8     
  Misses        424      424           
Flag Coverage Δ
unittests 93.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/training_manager.py 89.18% <ø> (ø)
GANDLF/cli/main_run.py 88.63% <100.00%> (+3.63%) ⬆️
testing/test_full.py 99.00% <100.00%> (+<0.01%) ⬆️
...NDLF/data/preprocessing/template_matching/utils.py 95.34% <0.00%> (-2.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarthakpati sarthakpati marked this pull request as ready for review January 20, 2023 03:05
@sarthakpati sarthakpati marked this pull request as draft January 20, 2023 03:09
…in-the-lossmetric-functionality' of https://github.com/sarthakpati/GaNDLF into 544-allow-a-specific-testing-data-csv-to-passed-in-main-cli
@sarthakpati sarthakpati marked this pull request as ready for review February 2, 2023 00:51
Copy link
Collaborator

@AlexanderGetka-cbica AlexanderGetka-cbica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarthakpati sarthakpati merged commit de72411 into mlcommons:master Feb 2, 2023
@sarthakpati sarthakpati deleted the 544-allow-a-specific-testing-data-csv-to-passed-in-main-cli branch February 2, 2023 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a specific testing data CSV to passed in main CLI
2 participants