Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed model saving when git repo not found #729

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

scap3yvt
Copy link
Collaborator

@scap3yvt scap3yvt commented Nov 8, 2023

Fixes #723

Proposed Changes

  • added another type of exception check during model saving

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Copy link
Contributor

github-actions bot commented Nov 8, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@scap3yvt
Copy link
Collaborator Author

scap3yvt commented Nov 8, 2023

CLA has been signed.

@sarthakpati sarthakpati self-requested a review November 8, 2023 22:33
@sarthakpati
Copy link
Collaborator

Thank you for your interest in contributing to GaNDLF! 😄

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #729 (b97fb05) into master (d099b7b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files         117      117           
  Lines        8221     8221           
=======================================
  Hits         7786     7786           
  Misses        435      435           
Flag Coverage Δ
unittests 94.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
GANDLF/utils/modelio.py 84.21% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sarthakpati sarthakpati merged commit 13abd55 into mlcommons:master Nov 11, 2023
16 of 17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
@scap3yvt scap3yvt deleted the 723_fix_for_no_git_repo branch November 11, 2023 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model saving is calling on git which causes an issue when the subprocess library is from the system
2 participants