Merge pull request #729 from scap3yvt/723_fix_for_no_git_repo

Fixed model saving when git repo not found
mlcommons · Nov 11, 2023 · 13abd55 · 13abd55
2 parents d099b7b + b97fb05
commit 13abd55
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/GANDLF/utils/modelio.py b/GANDLF/utils/modelio.py
@@ -155,13 +155,14 @@ def save_model(
     model_dict["parameters"] = params
 
     try:
+        # this will try to encode the git hash of the current GaNDLF codebase, and reverts to "None" if not found
         model_dict["git_hash"] = (
-            subprocess.check_output(["git", "rev-parse", "HEAD"])
+            subprocess.check_output(["git", "rev-parse", "HEAD"], cwd=os.getcwd())
             .decode("ascii")
             .strip()
         )
-    except subprocess.CalledProcessError:
-        model_dict["git_hash"] = None
+    except (subprocess.CalledProcessError, FileNotFoundError):
+        model_dict["git_hash"] = "None"
 
     torch.save(model_dict, path)