Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing commenting style for major functions #799

Merged
merged 83 commits into from
Feb 16, 2024

Conversation

scap3yvt
Copy link
Collaborator

@scap3yvt scap3yvt commented Feb 14, 2024

Fixes #798

Proposed Changes

  • added function type help and docstring comments
  • some raised errors have been changed to assertions for readability
  • added variable types of function variables
  • typing related updates for readability
    • tuple --> Tuple
    • list --> List
    • addition of Optional
  • no functional changes to code

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Copy link
Contributor

github-actions bot commented Feb 14, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the comments have been added on some of the most important portions of the code, which is great start!

It would be good to expand this for metrics and losses as well and include that in this PR.

Geeks-Sid
Geeks-Sid previously approved these changes Feb 15, 2024
GANDLF/utils/imaging.py Outdated Show resolved Hide resolved
GANDLF/utils/imaging.py Outdated Show resolved Hide resolved
GANDLF/utils/imaging.py Outdated Show resolved Hide resolved
GANDLF/utils/imaging.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@szmazurek szmazurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thanks for the updates! I have commented on just few things regarding the typings for List type in few places (they maybe were skipped on purpose, if so it should be left as that).

@sarthakpati
Copy link
Collaborator

I am very happy with the way this PR has been worked out. Special thanks to the contributions of @Geeks-Sid and @szmazurek for helping review this 🦣 PR. 😄

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Geeks-Sid Geeks-Sid merged commit 3af7fff into mlcommons:master Feb 16, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
@scap3yvt scap3yvt deleted the 798-standardize-commenting-style branch March 21, 2024 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize commenting style
4 participants