Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CK2/CM] fixing ambiguity with searching for variations in "cache"/"script" #243

Closed
gfursin opened this issue Jun 17, 2022 · 2 comments
Closed

[CK2/CM] fixing ambiguity with searching for variations in "cache"/"script" #243

gfursin opened this issue Jun 17, 2022 · 2 comments
Assignees
@arjunsuresh @gfursin
Labels
enhancement

Comments

@gfursin
Copy link
Contributor

gfursin commented Jun 17, 2022

As discussed during the conf-call, we should change "-" to "-" in "script" to support standard CM search for "cache" ...
gfursin added a commit to octoml/cm-mlops that referenced this issue Jun 17, 2022
@gfursin
* fixed logic to handle variations (-_): mlcommons/ck#243
416e593
gfursin added a commit that referenced this issue Jun 17, 2022
@gfursin
fixed logic to handle variations (-_): #243
581ea14
@gfursin
Copy link
Contributor Author

gfursin commented Jun 17, 2022

Done: 581ea14 .
@arjunsuresh - do you mind to test it on your examples, please! Thanks!

@gfursin
Copy link
Contributor Author

gfursin commented Jun 26, 2022

It is now fixed based on our latest discussions and tests.

@gfursin gfursin closed this as completed Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjunsuresh arjunsuresh

@gfursin gfursin

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arjunsuresh @gfursin