Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loadgen version generator to 3.1 #1452

Merged

Conversation

nvzhihanj
Copy link
Contributor

Still not fully fixed. Loadgen still throwing 3.0 as the version

@nvzhihanj nvzhihanj requested a review from a team as a code owner July 25, 2023 00:56
@github-actions
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@nvzhihanj
Copy link
Contributor Author

@pgmpablo157321 @arjunsuresh I still couldn't fully fix the issue after this PR. Can you advise what else I should change to make loadgen output 3.1 as the version?

@nv-ananjappa
Copy link
Contributor

nv-ananjappa commented Jul 25, 2023

@pgmpablo157321 Could you contribute a fix to make the merge work?

@arjunsuresh
Copy link
Contributor

@nvzhihanj It is working fine for me. I'm getting the below output in the log after these changes

arjunsuresh@Arjuns-MacBook-Pro ~ % cat test_results/Arjuns_MacBook_Pro.local-reference-cpu-tf-v2.13.0-default_config/resnet50/offline/performance/run_1/mlperf_log_detail.txt
:::MLLOG {"key": "loadgen_version", "value": "3.1 @ 1efeff1972", "time_ms": 0.021125, "namespace": "mlperf::logging", "event_type": "POINT_IN_TIME", "metadata": {"is_error": false, "is_warning": false, "file": "version.cc", "line_no": 54, "pid": 71353, "tid": 11698963673053299097}}

@mrasquinha-g mrasquinha-g merged commit 2da0c52 into mlcommons:master Jul 25, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants