Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Validate if Runner process exists #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidjurado
Copy link
Contributor

@davidjurado davidjurado commented Aug 26, 2022

When executing MLCube whiout Docker installed or running there is a long error message indicating that it's possible that Docker isn't running (Is the docker daemon running?) but this message is at the top of other outputs and it's hard to understand the actual error, the idea of this PR is to provide a better error message by checking if there aren't any Docker processes running and provide a simpler output.

Before:

imagen

After:

imagen

@github-actions
Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@dfeddema
Copy link
Contributor

We need to verify that either docker or podman are available. Both docker and podman use the docker runner, hence for the podman user docker will likely not be running and will not need to be for mlcube to work correctly using the docker runner. The podman user specifies "alias docker=podman" and uses the docker_runner. Installation instructions for podman on mac, windows, linux are here: https://podman.io/getting-started/installation

@davidjurado davidjurado changed the title Validate if Docker process is up and running [WIP] Validate if Docker process is up and running Sep 30, 2022
@davidjurado davidjurado changed the title [WIP] Validate if Docker process is up and running [WIP] Validate if Runner process exists Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants