Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSD logging #159

Closed
wants to merge 4 commits into from
Closed

SSD logging #159

wants to merge 4 commits into from

Conversation

christ1ne
Copy link
Contributor

Please review and see if the basics tags are in for ssd.

I know Taylor wants to update the logging code, I will update this branch once his fix is in.

@robieta
Copy link
Contributor

robieta commented Oct 15, 2018

I think some more detail would be useful. For instance:

  1. A detailed logging of the topology. Both the backbone and the SSD specific feature extractors. Checking that topologies match layer-for-layer will be quite helpful for automatic checking. (It tripped us up a couple times when porting, particularly since TorchVision uses a non-standard ResNet.)

  2. Tags outlining the data pipeline. SSD has a very elaborate input pipeline, with lots of opportunities for subtle mistakes. For instance when cropping there are aspect ratio thresholds, iou thresholds, criteria for accepting or rejecting a crop, etc.

@christ1ne
Copy link
Contributor Author

I think some more detail would be useful. For instance:

  1. A detailed logging of the topology. Both the backbone and the SSD specific feature extractors. Checking that topologies match layer-for-layer will be quite helpful for automatic checking. (It tripped us up a couple times when porting, particularly since TorchVision uses a non-standard ResNet.)
  2. Tags outlining the data pipeline. SSD has a very elaborate input pipeline, with lots of opportunities for subtle mistakes. For instance when cropping there are aspect ratio thresholds, iou thresholds, criteria for accepting or rejecting a crop, etc.

@robieta I've added more tags on your second point. Can you suggest how I can log a topology? Logging layer by layer is very tedious. Any specific pointer will be appreciated.

@robieta
Copy link
Contributor

robieta commented Oct 16, 2018

When logging the topology I put logging statements in the layer definition helper functions. i.e. https://github.com/mlperf/training/blob/master/image_classification/tensorflow/official/resnet/resnet_model.py#L60

The other option would be to use a summary tool. When I was comparing SSD, I found https://github.com/sksq96/pytorch-summary to be quite nice. (It is based on pytorch/pytorch#2001, I believe.) I know it would be somewhat troublesome to try to reach into TorchVision, but once it is in summary form it should be rather straightforward to iterate and produce a topology summary.

@christ1ne
Copy link
Contributor Author

This PR is replaced by #167

@christ1ne christ1ne closed this Oct 17, 2018
@christ1ne christ1ne deleted the ssd_logging branch October 17, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants