Pull in tag sets from various PRs #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robieta
requested review from
bitfort,
xyhuang,
nvpaulius,
petermattson and
christ1ne
|
I'm ok with the GNMT changes (tag names and ROOT_DIR_GNMT). |
|
looks good for ssd & minigo |
Fixed. Thanks! |
christ1ne
previously approved these changes
Oct 17, 2018
xyhuang
suggested changes
Oct 17, 2018
xyhuang
approved these changes
Oct 17, 2018
|
Alright! Changes are in PyPi. Thanks everyone! |
dagarcia-nvidia
pushed a commit
to dagarcia-nvidia/training
that referenced
this pull request
Feb 27, 2019
* fix some minor issues in dockerfile RUN echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selections fixes debconf: unable to initialize frontend: Dialog debconf: (TERM is not set, so the dialog frontend is not usable.) debconf: falling back to frontend: Readline debconf: unable to initialize frontend: Readline debconf: (This frontend requires a controlling tty.) debconf: falling back to frontend: Teletype dpkg-preconfigure: unable to re-open stdin: RUN apt-get update -y && apt-get install -y apt-utils fixes debconf: delaying package configuration, since apt-utils is not installed * remove redundant command * add -y to conda install and pip install * remove -y from pip install
ekrimer
pushed a commit
to ekrimer/training
that referenced
this pull request
Oct 10, 2019
* Pull in tag sets from various PRs * add gnmt print function * fix stack offset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that several PRs have merge conflicts due to the recent change in compliance utils structure. To make everyone's lives easier, I have pulled all of the changes into a util specific PR and will build 0.0.4 of the mlperf_compliance pip package once this PR is merged. That way you don't have to deal with resolving the merge confilcts; just add a line to requirements.txt
Notable changes:
GNMT: @szmigacz
#157
ROOT_DIR_GNMT. Please override that value in a main function.SSD: @christ1ne
#159
Transformer: @xyhuang
General:
I couldn't add @szmigacz as a reviewer, but let me know if you're fine with the GNMT changes.