Mldb 1209 statstable fncts noise injection #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d laplacian noise to the counts to allow the usage of stats tables training examples to train a classifier
Conflicts: plugins/stats_table_procedure.cc testing/testing.mk
Conflicts: jml/math/xdiv.h plugins/stats_table_procedure.cc testing/MLDB-873_stats_table_test.py testing/testing.mk
…9_statstable_fncts_noise_injection
…l issue where the rounding was always done to the lower value
…l issue where the rounding was always done to the lower value
…l issue where the rounding was always done to the lower value
guyd
commented
May 3, 2017
plugins/stats_table_procedure.cc
Outdated
| @@ -372,11 +376,19 @@ run(const ProcedureRunConfig & run, | |||
| /* STATS TABLE FUNCTION */ | |||
| /*****************************************************************************/ | |||
|
|
|||
| static const std::string INJECT_NOISE_DOC_STR = | |||
| "Inject laplacian noise to counts. This is useful when training " | |||
| "a classifier on the examples that were used to genereate the counts. " | |||
There was a problem hiding this comment.
Should we say that this is acceptable only if the count values are relatively large compare to the noise? How large?
There was a problem hiding this comment.
I suggest we add more on label data leakage in the documentation of stats table functions. I feel this comment is hard to understand without an example.
|
|
||
| mldb = mldb_wrapper.wrap(mldb) # noqa | ||
|
|
||
| class MLDB1209StatstableBiasNoiseTest(MldbUnitTest): # noqa |
There was a problem hiding this comment.
I had not realized that this is also lacking some validation point. I will add these too.
mathieumb
reviewed
May 5, 2017
| { | ||
| } | ||
|
|
||
| bool injectNoise; |
There was a problem hiding this comment.
We're trying to transition to C++ 11 member initialization (i.e. bool injectNoise = false)
mathieumb
reviewed
May 5, 2017
| @@ -245,6 +249,7 @@ struct StatsTablePosNegFunctionConfig { | |||
|
|
|||
| std::string outcomeToUse; | |||
|
|
|||
| bool injectNoise; | |||
mathieumb
reviewed
May 5, 2017
|
|
||
| struct NoiseInjector { | ||
|
|
||
| NoiseInjector() : mu(0), b(3) |
There was a problem hiding this comment.
Initialize defaults in the declaration and kill the constructor.
mathieumb
suggested changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Francois' branch with a change by vbisserie to make it compile and a unit test for the noise generation functions. A small issue was found in the NoiseInjector::add_noise where the rounding was always done to the lower value.