Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounts tab navigation #811

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Accounts tab navigation #811

merged 3 commits into from
Dec 17, 2023

Conversation

boscojwho
Copy link
Contributor

Pull Request Information

About this Pull Request

  • Opts in the new accounts views into tab bar navigation (only dismiss, no scroll to top).
  • Moves account discussion languages view into separate view, instead of nesting it inside NavigationLink. This is necessary because SwiftUI has trouble figuring out which dismiss action to get when there are two full-screen views inside a single view definition.

@boscojwho
- Opt-in to tab bar navigation in account views.
b783676
@boscojwho
- Add AccountDiscussionLanguagesView, as it is a full view.
0fef299 
- Move discussion languages logic to new view.
- Add accountDiscussionLanguage route.
@boscojwho boscojwho requested a review from a team as a code owner December 14, 2023 03:48
@boscojwho boscojwho requested review from JakeShirley and EricBAndrews and removed request for a team December 14, 2023 03:48
EricBAndrews
EricBAndrews approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@boscojwho boscojwho merged commit 1788e38 into dev Dec 17, 2023
4 checks passed
@boscojwho boscojwho deleted the bosco/accounts-tab-navigation branch December 17, 2023 01:22
EricBAndrews pushed a commit that referenced this pull request Dec 18, 2023
@boscojwho @EricBAndrews
Accounts tab navigation (#811)
db852a9
EricBAndrews pushed a commit that referenced this pull request Dec 18, 2023
@boscojwho @EricBAndrews
Accounts tab navigation (#811)
d474c26
EricBAndrews pushed a commit that referenced this pull request Dec 18, 2023
@boscojwho @EricBAndrews
Accounts tab navigation (#811)
37fa40b
EricBAndrews pushed a commit that referenced this pull request Dec 18, 2023
@boscojwho @EricBAndrews
Accounts tab navigation (#811)
c9fc505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boscojwho @EricBAndrews