Unified Logging #888
Unified Logging #888
Conversation
| private let logger: Logger | ||
|
|
||
| required init(file: String = #fileID) { | ||
| self.logger = Logger(subsystem: AppConstants.loggerSubSystem, category: file) |
There was a problem hiding this comment.
I made the category be the file name for now. Not sure if we should have defined categories for logging, such as "user interaction", "networking", etc. It may be a lot to maintain and enforce going forward if we do that.
|
It would be nice to have a linting rule to warn people using I see the file in root, of course. I'll update the rule at the end. |
|
I like the concept! I'm tentatively scoping this for 1.3--pending the face ID PR, we're in full bugfix mode for the 1.2 release. Re: categorization, I think that would be a good idea--there's a lot of discussion to be had about what those categories should be, but the added dev time categorizing logs has in my experience always paid off eventually. We might want to look into an architecture like this one, where categorized loggers are defined as static properties on the Logger class--that saves us from needing to dependency inject or instantiate loggers everywhere |
|
Yeah makes sense with categorization. I didn't make it statically defined because I have the file name coming in through the init. Once we define the categories, I won't need to do that. |
EricBAndrews
force-pushed
the
dev
branch
4 times, most recently
from
0834c01
to
e506ba1
Compare
Checklist
- Unified Logging Solution #124
Pull Request Information
About this Pull Request
This is just a proof of concept for logging right now, with minimal files edited. Want to get consensus before I modify every file with logging. @Sjmarf @EricBAndrews
Additional Context
N/A for now