Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Step.php #1

Open
wants to merge 1 commit into
base: 2.2
Choose a base branch
from
Open

Update Step.php #1

wants to merge 1 commit into from

Conversation

mlespiau
Copy link
Owner

Prevent division by zero when using acceptPopup and closePopup in Acceptance tests.

Related to Codeception#3922

Prevent division by zero when using acceptPopup and closePopup in Acceptance tests.
@edno
Copy link

edno commented Jan 16, 2017

You're patch will prevent the division by zero, but it will hide the problem rather really fixing it.

Since there no need to reach this part of the function when there's no arguments, I would suggest to save time by quitting the function if $argumentCount equals 0 after line 94.

if ($argumentCount == 0) {
    return '';
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants