Replace deprecated method trainer.disable_validation() (#5075)

Signed-off-by: Liang Zhang <liang.zhang@databricks.com>
mlflow · Nov 17, 2021 · 7b4ab0e · 7b4ab0e
1 parent 5ad33e0
commit 7b4ab0e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/mlflow/pytorch/_pytorch_autolog.py b/mlflow/pytorch/_pytorch_autolog.py
@@ -127,7 +127,7 @@ def on_train_epoch_end(
             # If validation loop is enabled (meaning `validation_step` is overridden),
             # log metrics in `on_validaion_epoch_end` to avoid logging the same metrics
             # records twice
-            if trainer.disable_validation:
+            if not trainer.enable_validation:
                 self._log_metrics(trainer, pl_module)
 
         @rank_zero_only

diff --git a/tests/pytorch/test_pytorch_autolog.py b/tests/pytorch/test_pytorch_autolog.py
@@ -92,7 +92,7 @@ def test_pytorch_autolog_logs_expected_data(pytorch_model):
 
 def test_pytorch_autolog_logs_expected_metrics_without_validation(pytorch_model_without_validation):
     trainer, run = pytorch_model_without_validation
-    assert trainer.disable_validation
+    assert not trainer.enable_validation
 
     client = mlflow.tracking.MlflowClient()
     for metric_key in ["loss", "train_acc"]: