-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Increase maximum param value length to 500 (#6358)
* increase validation of maximum param value length from 250 to 500 (squashed) Signed-off-by: Jan Sindlar <jan.sindlar@eureka.ai> * 1. added test for exceeding max length. 2. lint. 3. validation logic addresses null Signed-off-by: Jan Sindlar <jan.sindlar@eureka.ai> * file store should test already stringified params Signed-off-by: Jan Sindlar <jan.sindlar@eureka.ai> * update alembic chain Signed-off-by: Jan Sindlar <jan.sindlar@eureka.ai> * Autoformat: https://github.com/mlflow/mlflow/actions/runs/2800398158 Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com> * Update tests/store/tracking/test_file_store.py Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Signed-off-by: Jan Sindlar <jan.sindlar@eureka.ai> Co-authored-by: Jan Sindlar <jan.sindlar@eureka.ai> Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com>
- Loading branch information
1 parent
80564db
commit d4109d0
Showing
14 changed files
with
97 additions
and
13 deletions.
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
mlflow/store/db_migrations/versions/cc1f77228345_change_param_value_length_to_500.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
"""change param value length to 500 | ||
Revision ID: cc1f77228345 | ||
Revises: 0c779009ac13 | ||
Create Date: 2022-08-04 22:40:56.960003 | ||
""" | ||
from alembic import op | ||
import sqlalchemy as sa | ||
|
||
|
||
# revision identifiers, used by Alembic. | ||
revision = "cc1f77228345" | ||
down_revision = "0c779009ac13" | ||
branch_labels = None | ||
depends_on = None | ||
|
||
|
||
def upgrade(): | ||
""" | ||
Enlarge the maximum param value length to 500. | ||
""" | ||
with op.batch_alter_table("params") as batch_op: | ||
batch_op.alter_column( | ||
"value", | ||
existing_type=sa.String(250), | ||
type_=sa.String(500), | ||
existing_nullable=False, | ||
nullable=False, | ||
) | ||
|
||
|
||
def downgrade(): | ||
pass |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters