-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Attribute lifecycle_stage
of an experiment and its runs is not set to LifecycleStage.DELETED
when the experiment is deleted in FileStore backend
#8177
Labels
Comments
github-actions
bot
added
the
area/tracking
Tracking service, tracking client APIs, autologging
label
Apr 5, 2023
mariusschlegel
changed the title
[BUG] Attribute
[BUG] Attribute Apr 5, 2023
lifecycle_stage
is not set to LifecycleStage.DELETED
when an experiment is deleted in file store backendlifecycle_stage
is not set to LifecycleStage.DELETED
when an experiment is deleted in FileStore backend
mariusschlegel
changed the title
[BUG] Attribute
[BUG] Attribute Apr 5, 2023
lifecycle_stage
is not set to LifecycleStage.DELETED
when an experiment is deleted in FileStore backendlifecycle_stage
of an experiment and its runs is not set to LifecycleStage.DELETED
when the experiment is deleted in FileStore backend
mariusschlegel
added a commit
to mariusschlegel/mlflow
that referenced
this issue
Apr 5, 2023
implementation (mlflow#8177) Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
33 tasks
Thank you ! I reviewed your PR. |
mariusschlegel
added a commit
to mariusschlegel/mlflow
that referenced
this issue
Apr 6, 2023
implementation (mlflow#8177) Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
Thanks a lot for reviewing. I have revised the PR according to your comments. |
@BenWilson2 @dbczumar @harupy @WeichenXu123 Please assign a maintainer and start triaging this issue. |
WeichenXu123
pushed a commit
that referenced
this issue
Apr 13, 2023
…ntation (#8178) * Fix delete_experiment and restore_experiment in file_store implementation (#8177) Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de> * Sort imports with isort Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de> * Replace exception with logger warning Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de> * Fix implementation for passing tests Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de> * Sort imports with isort Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de> * Fixes and cleanup Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de> * Add new tests and fix existing tests Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de> * Revert "Sort imports with isort" This reverts commit 537a6d2. Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de> * Revert "Sort imports with isort" This reverts commit fc161a0. Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de> --------- Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issues Policy acknowledgement
Willingness to contribute
Yes. I can contribute a fix for this bug independently.
MLflow version
System information
Describe the problem
When using the FileStore backend and deleting/restoring an experiment, the
lifecycle_stage
attribute of the experiment and its runs is not persistently set/updated toLifecycleStage.DELETED
/LifecycleStage.ACTIVE
(see https://github.com/mlflow/mlflow/blob/master/mlflow/store/tracking/file_store.py#L418). This is contrary to the implementation of the SQLAlchemyStore backend (see https://github.com/mlflow/mlflow/blob/master/mlflow/store/tracking/sqlalchemy_store.py#L395).Tracking information
Code to reproduce issue
Stack trace
Other info / logs
What component(s) does this bug affect?
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingWhat interface(s) does this bug affect?
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportWhat language(s) does this bug affect?
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesWhat integration(s) does this bug affect?
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsThe text was updated successfully, but these errors were encountered: