Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Attribute lifecycle_stage of an experiment and its runs is not set to LifecycleStage.DELETED when the experiment is deleted in FileStore backend #8177

Closed
2 of 22 tasks
mariusschlegel opened this issue Apr 5, 2023 · 3 comments
Labels
area/tracking Tracking service, tracking client APIs, autologging bug Something isn't working

Comments

@mariusschlegel
Copy link
Contributor

mariusschlegel commented Apr 5, 2023

Issues Policy acknowledgement

  • I have read and agree to submit bug reports in accordance with the issues policy

Willingness to contribute

Yes. I can contribute a fix for this bug independently.

MLflow version

  • Client: 2.2.2
  • Tracking server: 2.2.2

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Fedora Linux 37
  • Python version: 3.10.10

Describe the problem

When using the FileStore backend and deleting/restoring an experiment, the lifecycle_stage attribute of the experiment and its runs is not persistently set/updated to LifecycleStage.DELETED/LifecycleStage.ACTIVE (see https://github.com/mlflow/mlflow/blob/master/mlflow/store/tracking/file_store.py#L418). This is contrary to the implementation of the SQLAlchemyStore backend (see https://github.com/mlflow/mlflow/blob/master/mlflow/store/tracking/sqlalchemy_store.py#L395).

Tracking information

REPLACE_ME

Code to reproduce issue

REPLACE_ME

Stack trace

REPLACE_ME

Other info / logs

REPLACE_ME

What component(s) does this bug affect?

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

What interface(s) does this bug affect?

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

What language(s) does this bug affect?

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

What integration(s) does this bug affect?

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations
@mariusschlegel mariusschlegel added the bug Something isn't working label Apr 5, 2023
@github-actions github-actions bot added the area/tracking Tracking service, tracking client APIs, autologging label Apr 5, 2023
@mariusschlegel mariusschlegel changed the title [BUG] Attribute lifecycle_stage is not set to LifecycleStage.DELETED when an experiment is deleted in file store backend [BUG] Attribute lifecycle_stage is not set to LifecycleStage.DELETED when an experiment is deleted in FileStore backend Apr 5, 2023
@mariusschlegel mariusschlegel changed the title [BUG] Attribute lifecycle_stage is not set to LifecycleStage.DELETED when an experiment is deleted in FileStore backend [BUG] Attribute lifecycle_stage of an experiment and its runs is not set to LifecycleStage.DELETED when the experiment is deleted in FileStore backend Apr 5, 2023
mariusschlegel added a commit to mariusschlegel/mlflow that referenced this issue Apr 5, 2023
implementation (mlflow#8177)

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
@WeichenXu123
Copy link
Collaborator

Thank you ! I reviewed your PR.

mariusschlegel added a commit to mariusschlegel/mlflow that referenced this issue Apr 6, 2023
implementation (mlflow#8177)

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
@mariusschlegel
Copy link
Contributor Author

Thanks a lot for reviewing. I have revised the PR according to your comments.

@mlflow-automation
Copy link
Collaborator

@BenWilson2 @dbczumar @harupy @WeichenXu123 Please assign a maintainer and start triaging this issue.

WeichenXu123 pushed a commit that referenced this issue Apr 13, 2023
…ntation (#8178)

* Fix delete_experiment and restore_experiment in file_store
implementation (#8177)

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>

* Sort imports with isort

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>

* Replace exception with logger warning

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>

* Fix implementation for passing tests

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>

* Sort imports with isort

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>

* Fixes and cleanup

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>

* Add new tests and fix existing tests

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>

* Revert "Sort imports with isort"

This reverts commit 537a6d2.

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>

* Revert "Sort imports with isort"

This reverts commit fc161a0.

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>

---------

Signed-off-by: Marius Schlegel <marius.schlegel@tu-ilmenau.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracking Tracking service, tracking client APIs, autologging bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants