Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore dataset tracking flag #10992

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

daniellok-db
Copy link
Collaborator

@daniellok-db daniellok-db commented Feb 3, 2024

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/10992/merge

Checkout with GitHub CLI

gh pr checkout 10992

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

This got mistakenly flipped in the #10864 (https://github.com/mlflow/mlflow/pull/10864/files#diff-db75911f744e5ac598c4742a9b1852026545e2d91eb49f5d0f966370286f7d92R12)

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Reverted a change that caused datasets to not be visible in the UI

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Copy link

github-actions bot commented Feb 3, 2024

Documentation preview for 9a95b15 will be available here when this CircleCI job completes successfully.

More info

@github-actions github-actions bot added area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/bug-fix Mention under Bug Fixes in Changelogs. labels Feb 3, 2024
Copy link
Member

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Let's get this marked for a patch release next week (there is an additional fix that's being worked on for a different, more serious issue as well, so there's no rush on this one.

@daniellok-db daniellok-db merged commit 8968aa7 into mlflow:master Feb 3, 2024
45 checks passed
daniellok-db added a commit to daniellok-db/mlflow that referenced this pull request Feb 6, 2024
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
daniellok-db added a commit that referenced this pull request Feb 6, 2024
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
lu-wang-dl pushed a commit to lu-wang-dl/mlflow that referenced this pull request Feb 6, 2024
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Signed-off-by: lu-wang-dl <lu.wang@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants