Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure RegisteredModel, RegisteredModelSearch and ModelVersion, ModelVersionSearch equality #12013

Merged
merged 2 commits into from
May 15, 2024

Conversation

artjen
Copy link
Collaborator

@artjen artjen commented May 15, 2024

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/12013/merge

Checkout with GitHub CLI

gh pr checkout 12013

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Title.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Manual testing included getting model versions from Unity Catalog using get_model_version and search_model_versions and asserting equality.

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Signed-off-by: Arthur Jenoudet <arthur.jenoudet@databricks.com>
Copy link

Documentation preview for 0090f9c will be available when this CircleCI job
completes successfully.

More info

@github-actions github-actions bot added area/model-registry Model registry, model registry APIs, and the fluent client calls for model registry rn/bug-fix Mention under Bug Fixes in Changelogs. labels May 15, 2024
@kriscon-db
Copy link
Collaborator

Can you test this w/in a databricks environment that is replicating what the LITE test is doing?

@artjen
Copy link
Collaborator Author

artjen commented May 15, 2024

Can you test this w/in a databricks environment that is replicating what the LITE test is doing?

@kriscon-db I've shared a notebook with you demonstrating the DUST test functionality.

@shichengzhou-db
Copy link
Collaborator

thanks for the fix!
could we verify if uc model registry dust test passes now?

# local
bazel run //uc-model-registry:UcModelRegistryDustSuite

# staging workspace
bazel run //uc-model-registry:UcModelRegistryDustSuite -- --proxy consolidated-staging

@artjen

@artjen
Copy link
Collaborator Author

artjen commented May 15, 2024

# local
bazel run //uc-model-registry:UcModelRegistryDustSuite

# staging workspace
bazel run //uc-model-registry:UcModelRegistryDustSuite -- --proxy consolidated-staging

@shichengzhou-db both passed when running from devbox and incorporating these changes.

@artjen artjen merged commit acfa074 into mlflow:master May 15, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/model-registry Model registry, model registry APIs, and the fluent client calls for model registry patch-2.12.3 rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants