Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pyfunc load_model to avoid deprecation warning #2009

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

dbczumar
Copy link
Collaborator

What changes are proposed in this pull request?

Calling mlflow.pyfunc.load_model currently produces a deprecation warning because its implementation invokes the deprecated mlflow.pyfunc.load_pyfunc function. I filed #1980 to remove load_pyfunc from the code base entirely; however, this requires a bit more testing / diligence than I have time to invest prior to the next release. Accordingly, it would be great to get this refactor merged quickly instead.

How is this patch tested?

Existing unit tests, manual tests

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s) does this PR affect?

  • UI
  • CLI
  • API
  • REST-API
  • Examples
  • Docs
  • Tracking
  • Projects
  • Artifacts
  • Models
  • Scoring
  • Serving
  • R
  • Java
  • Python

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@dbczumar dbczumar requested a review from mparkhe October 28, 2019 19:49
Copy link
Collaborator

@mparkhe mparkhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@dbczumar dbczumar merged commit afe12ca into mlflow:master Oct 28, 2019
@sueann sueann added the rn/none List under Small Changes in Changelogs. label Oct 29, 2019
avflor pushed a commit to avflor/mlflow that referenced this pull request Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants