Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub regex to match http(s):// URLs in addition to SSH URLs #235

Merged
merged 4 commits into from
Aug 3, 2018

Conversation

smurching
Copy link
Collaborator

@smurching smurching commented Aug 3, 2018

  • Updates the regex used to identify GitHub repo URLs in the frontend to match HTTP(S) URLs, and adds a unit test verifying this behavior
  • Also display a link to a specific GitHub version in the run view page

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #235 into master will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #235      +/-   ##
=========================================
+ Coverage   55.46%   55.5%   +0.03%     
=========================================
  Files         100     100              
  Lines        5028    5027       -1     
=========================================
+ Hits         2789    2790       +1     
+ Misses       2239    2237       -2
Impacted Files Coverage Δ
mlflow/server/js/src/components/RunView.js 0% <ø> (ø) ⬆️
mlflow/server/js/src/utils/Utils.js 38% <33.33%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dccc0d4...ef0236b. Read the comment docs.

@aarondav aarondav added the LGTM label Aug 3, 2018
@aarondav aarondav merged commit 6c30192 into mlflow:master Aug 3, 2018
jdlesage pushed a commit to jdlesage/mlflow that referenced this pull request Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants