Fix bug with list artifacts UI. #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarondav
reviewed
Aug 14, 2018
| @@ -2,17 +2,21 @@ export class ArtifactNode { | |||
| constructor(isRoot, fileInfo, children) { | |||
| this.isRoot = isRoot; | |||
| this.isLoaded = false; | |||
| // fileInfo should not be defined for the root node. | |||
There was a problem hiding this comment.
Does this comment pertain to something?
There was a problem hiding this comment.
Yup, it just means that we don't expect fileInfo to be set on the root ArtifactNode.
aarondav
reviewed
Aug 14, 2018
| @@ -206,6 +206,7 @@ const artifactsByRunUuid = (state = {}, action) => { | |||
| let artifactNode = state[runUuid] || new ArtifactNode(true); | |||
| // Make deep copy. | |||
| artifactNode = artifactNode.deepCopy(); | |||
| console.log(artifactNode); | |||
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 55.71% 55.87% +0.16%
==========================================
Files 108 108
Lines 5523 5525 +2
==========================================
+ Hits 3077 3087 +10
+ Misses 2446 2438 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the artifacts UI, when we listed a new directory, the
deepCopyfunction on anArtifactNodefails to copy theisLoadedproperty. We should copy it so the UI doesn't get confused.Also, the old
loading...message had a hideous green color. This PR changes it.Before:
After (with some spinning):