Update client to pass request headers created by all RequestHeaderProviders #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyxu-db
force-pushed
the
ML-13222
branch
2 times, most recently
from
e9bf15b
to
369698a
Compare
github-actions
bot
added
area/tracking
jimmyxu-db
changed the title
dbczumar
reviewed
Feb 3, 2021
dbczumar
reviewed
Feb 3, 2021
dbczumar
reviewed
Feb 3, 2021
dbczumar
reviewed
Feb 3, 2021
| headers = dict(_DEFAULT_HEADERS) | ||
| from mlflow.tracking.request_header.registry import resolve_request_headers | ||
|
|
||
| headers = dict({**_DEFAULT_HEADERS, **resolve_request_headers()}) |
There was a problem hiding this comment.
Is there a way we can easily unit test the addition of these provider headers to a request?
dbczumar
reviewed
Feb 3, 2021
There was a problem hiding this comment.
@jimmyxu-db This is awesome! Do you have a manual test plan that you can share (i.e. one that tries this out on Databricks)?
Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com>
Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com>
Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com
Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com>
Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com>
Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com>
Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com>
dbczumar
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
LGTM once lint failures are addressed. Thanks @jimmyxu-db !
eedeleon
pushed a commit
to eedeleon/mlflow
that referenced
this pull request
Feb 5, 2021
…viders (mlflow#4042) * added request header provider registry Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * added registry tests Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * updated rest_utils Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * fixed circular import Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * fixed dict syntax Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * f-string Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * f-string Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * removed unused param Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * added test to rest_utils Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com>
aloosley
pushed a commit
to aloosley/mlflow
that referenced
this pull request
Feb 9, 2021
…viders (mlflow#4042) * added request header provider registry Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * added registry tests Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * updated rest_utils Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * fixed circular import Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * fixed dict syntax Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * f-string Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * f-string Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * removed unused param Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * added test to rest_utils Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com>
harupy
pushed a commit
to chauhang/mlflow
that referenced
this pull request
Apr 8, 2021
…viders (mlflow#4042) * added request header provider registry Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * added registry tests Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * updated rest_utils Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * fixed circular import Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * fixed dict syntax Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * f-string Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * f-string Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * removed unused param Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * added test to rest_utils Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
pushed a commit
to wamartin-aml/mlflow
that referenced
this pull request
Jun 7, 2021
…viders (mlflow#4042) * added request header provider registry Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * added registry tests Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * updated rest_utils Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * fixed circular import Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * fixed dict syntax Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * f-string Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * f-string Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * removed unused param Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * added test to rest_utils Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> * lint Signed-off-by: Jimmy Xu <jimmy.xu@databricks.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
|
|
20 tasks
|
Has any thought been given to implementing an equivalent for the R client? I see no way to easily modify outgoing requests in https://github.com/mlflow/mlflow/blob/master/mlflow/R/mlflow/R/tracking-rest.R#L34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
In this pull request, we will pass all request headers created by RequestHeaderProviders in outgoing requests. This follows up #3946
How is this patch tested?
New unit tests
Release Notes
MLflow will now add all request headers from registered RequestHeaderProviders to outgoing requests.
Is this a user-facing change?
All outgoing requests will now have request headers provided by all RequestHeaderProviders attached.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: Local serving, model deployment tools, spark UDFsarea/server-infra: MLflow server, JavaScript dev serverarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, JavaScript, plottingarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes